Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8279182: MakeZipReproducible ZipEntry timestamps not localized to UTC #205

Conversation

andrew-m-leonard
Copy link

@andrew-m-leonard andrew-m-leonard commented Mar 8, 2022

This patch is for reproducible builds whereby the reproducible src.zip timestamps where not being localized to UTC, hence src.zip differed depending on what local build machine timezone was set to.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8279182: MakeZipReproducible ZipEntry timestamps not localized to UTC

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/205/head:pull/205
$ git checkout pull/205

Update a local copy of the PR:
$ git checkout pull/205
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/205/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 205

View PR using the GUI difftool:
$ git pr show -t 205

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/205.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 8, 2022

👋 Welcome back aleonard! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport bc0466c7ca57f14b1e6285e2a39755d57c8de376 8279182: MakeZipReproducible ZipEntry timestamps not localized to UTC Mar 8, 2022
@openjdk
Copy link

openjdk bot commented Mar 8, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 8, 2022

@andrew-m-leonard This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279182: MakeZipReproducible ZipEntry timestamps not localized to UTC

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • a15455f: 8278948: compiler/vectorapi/reshape/TestVectorCastAVX1.java crashes in assembler
  • eee17fb: 8265317: [vector] assert(payload->is_object()) failed: expected 'object' value for scalar-replaced boxed vector but got: NULL
  • f820a3c: 8278966: two microbenchmarks tests fail "assert(!jvms->method()->has_exception_handlers()) failed: no exception handler expected" after JDK-8275638
  • a8775f1: 8275638: GraphKit::combine_exception_states fails with "matching stack sizes" assert
  • ff1ef50: 8273056: java.util.random does not correctly sample exponential or Gaussian distributions
  • e2103de: 8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 8, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 8, 2022

Webrevs

@andrew-m-leonard
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 9, 2022
@openjdk
Copy link

openjdk bot commented Mar 9, 2022

@andrew-m-leonard
Your change (at version 5b4a5db) is now ready to be sponsored by a Committer.

@gnu-andrew
Copy link
Member

/sponsor

@gnu-andrew
Copy link
Member

Looks good to me. Thanks for backporting.

@openjdk
Copy link

openjdk bot commented Mar 9, 2022

Going to push as commit 673c585.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 11a5bbd: 8270468: TestRangeCheckEliminated fails because methods are not compiled
  • a946f04: 8269129: Multiple tier1 tests in hotspot/jtreg/compiler are failing for client VMs
  • a15455f: 8278948: compiler/vectorapi/reshape/TestVectorCastAVX1.java crashes in assembler
  • eee17fb: 8265317: [vector] assert(payload->is_object()) failed: expected 'object' value for scalar-replaced boxed vector but got: NULL
  • f820a3c: 8278966: two microbenchmarks tests fail "assert(!jvms->method()->has_exception_handlers()) failed: no exception handler expected" after JDK-8275638
  • a8775f1: 8275638: GraphKit::combine_exception_states fails with "matching stack sizes" assert
  • ff1ef50: 8273056: java.util.random does not correctly sample exponential or Gaussian distributions
  • e2103de: 8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 9, 2022
@openjdk openjdk bot closed this Mar 9, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 9, 2022
@openjdk
Copy link

openjdk bot commented Mar 9, 2022

@gnu-andrew @andrew-m-leonard Pushed as commit 673c585.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants