-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8320597: RSA signature verification fails on signed data that does not encode params correctly #2052
Conversation
👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
DerOutputStream oidout = new DerOutputStream(); | ||
oidout.putOID(oid); | ||
out.write(DerValue.tag_Sequence, oidout); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we write these lines in the same way as in the 22 patch? (out.write(DerValue.tag_Sequence, new DerOutputStream().putOID(oid));)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we can not. DerOutputStream::putOID() was changed in JDK20 to return itself : JDK-8294987
It is not backported to JDK17, so putOID returns void
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this backport. Looks good to me. Before moving forward, I'd suggest to wait until the integration of 8302017 and making sure that there aren't any other changes that affect this backport.
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout JDK-8320597
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
|
I requested jdk17u Maintainer approval. |
@alexeybakhtin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 5653d2d. |
@alexeybakhtin Pushed as commit 5653d2d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport is not clean because encodeSignature and decodeSignature methods belong to the RSASignature class ( not RSAUtil ).
This is the reason for no changes in the RSAUtil class.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2052/head:pull/2052
$ git checkout pull/2052
Update a local copy of the PR:
$ git checkout pull/2052
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2052/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2052
View PR using the GUI difftool:
$ git pr show -t 2052
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2052.diff
Webrev
Link to Webrev Comment