8320798: Console read line with zero out should zero out underlying buffer

[GoeLin]

I think thsi should be backported to fix the underlying issue.

Console has been improved a lot in 21 and later, so the original patch does not apply well.
Console was turned into a sealed class. The implementation was moved to JdkConsoleImpl.
(8298416: Console should be declared sealed, 8298971: Move Console implementation into jdk internal package)
Later, the class moved to jdk.internal.le and JLine was added (8295803: Console should be usable in jshell and other environments).
I moved the coding to Console.java. We verified with our testcase that the issue is actually fixed. The two follow up fixes are not needed as 8295803 is not in 17.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8320798 needs maintainer approval

Issue

• JDK-8320798: Console read line with zero out should zero out underlying buffer (Bug - P4 - Approved)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2053/head:pull/2053
$ git checkout pull/2053

Update a local copy of the PR:
$ git checkout pull/2053
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2053/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2053

View PR using the GUI difftool:
$ git pr show -t 2053

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2053.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (508f1186)

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320798: Console read line with zero out should zero out underlying buffer

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 969f105: 8302017: Allocate BadPaddingException only if it will be thrown

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[GoeLin]

/integrate

[openjdk]

Going to push as commit 48c8478.
Since your change was applied there have been 5 commits pushed to the master branch:

• 5653d2d: 8320597: RSA signature verification fails on signed data that does not encode params correctly
• dcba538: 8283400: [macos] a11y : Screen magnifier does not reflect JRadioButton value change
• 5fe2d51: 8297968: Crash in PrintOptoAssembly
• 873148e: 8273454: C2: Transform (-a)(-b) into ab
• 969f105: 8302017: Allocate BadPaddingException only if it will be thrown

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit 48c8478.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.