Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313621: test/jdk/jdk/internal/math/FloatingDecimal/TestFloatingDecimal should use RandomFactory #2055

Conversation

SoniaZaldana
Copy link
Member

@SoniaZaldana SoniaZaldana commented Dec 15, 2023

Hi all,

This pull request contains a backport of commit 864a876e from the openjdk/jdk repository.

The commit being backported was authored by Brian Burkhalter on 30 Oct 2023 and was reviewed by Raffaello Giulietti.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8313621 needs maintainer approval

Issue

  • JDK-8313621: test/jdk/jdk/internal/math/FloatingDecimal/TestFloatingDecimal should use RandomFactory (Bug - P5 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2055/head:pull/2055
$ git checkout pull/2055

Update a local copy of the PR:
$ git checkout pull/2055
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2055/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2055

View PR using the GUI difftool:
$ git pr show -t 2055

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2055.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 15, 2023

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 864a876ebfdf745b0e1f875c3e3668380f2498a7 8313621: test/jdk/jdk/internal/math/FloatingDecimal/TestFloatingDecimal should use RandomFactory Dec 15, 2023
@openjdk
Copy link

openjdk bot commented Dec 15, 2023

This backport pull request has now been updated with issue from the original commit.

@SoniaZaldana SoniaZaldana marked this pull request as ready for review December 18, 2023 16:24
@openjdk
Copy link

openjdk bot commented Dec 18, 2023

⚠️ @SoniaZaldana This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added rfr Pull request is ready for review approval labels Dec 18, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 18, 2023

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Dec 19, 2023

/approve yes

@openjdk
Copy link

openjdk bot commented Dec 19, 2023

@GoeLin
8313621: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Dec 19, 2023

@SoniaZaldana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313621: test/jdk/jdk/internal/math/FloatingDecimal/TestFloatingDecimal should use RandomFactory

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 00d74be: 8314220: Configurable InlineCacheBuffer size
  • 9a104e0: 8318562: Computational test more than 2x slower when AVX instructions are used
  • 5ed1926: 8317507: C2 compilation fails with "Exceeded _node_regs array"
  • 7973bfe: 8321215: Incorrect x86 instruction encoding for VSIB addressing mode
  • c555fe3: 8315680: java/lang/ref/ReachabilityFenceTest.java should run with -Xbatch
  • 3809b71: 8293117: Add atomic bitset functions
  • a032136: 8295068: SSLEngine throws NPE parsing CertificateRequests
  • f033de0: 8274632: Possible pointer overflow in PretouchTask chunk claiming
  • c44bd2b: 8320001: javac crashes while adding type annotations to the return type of a constructor
  • 97d8ed2: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton
  • ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/dcba538585b89f0378d2682e2fcd0fac489c40f6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 19, 2023
@SoniaZaldana
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 19, 2023
@openjdk
Copy link

openjdk bot commented Dec 19, 2023

@SoniaZaldana
Your change (at version 92c7ec9) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 19, 2023

Going to push as commit 9d2467b.
Since your change was applied there have been 13 commits pushed to the master branch:

  • a84f19f: 8263256: Test java/net/Inet6Address/serialize/Inet6AddressSerializationTest.java fails due to dynamic reconfigurations of network interface during test
  • 00d74be: 8314220: Configurable InlineCacheBuffer size
  • 9a104e0: 8318562: Computational test more than 2x slower when AVX instructions are used
  • 5ed1926: 8317507: C2 compilation fails with "Exceeded _node_regs array"
  • 7973bfe: 8321215: Incorrect x86 instruction encoding for VSIB addressing mode
  • c555fe3: 8315680: java/lang/ref/ReachabilityFenceTest.java should run with -Xbatch
  • 3809b71: 8293117: Add atomic bitset functions
  • a032136: 8295068: SSLEngine throws NPE parsing CertificateRequests
  • f033de0: 8274632: Possible pointer overflow in PretouchTask chunk claiming
  • c44bd2b: 8320001: javac crashes while adding type annotations to the return type of a constructor
  • ... and 3 more: https://git.openjdk.org/jdk17u-dev/compare/dcba538585b89f0378d2682e2fcd0fac489c40f6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 19, 2023
@openjdk openjdk bot closed this Dec 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 19, 2023
@openjdk
Copy link

openjdk bot commented Dec 19, 2023

@shipilev @SoniaZaldana Pushed as commit 9d2467b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants