Skip to content

8318961: increase javacserver connection timeout values and max retry attempts#2063

Closed
shipilev wants to merge 2 commits intoopenjdk:masterfrom
shipilev:JDK-8318961-javac-timeout
Closed

8318961: increase javacserver connection timeout values and max retry attempts#2063
shipilev wants to merge 2 commits intoopenjdk:masterfrom
shipilev:JDK-8318961-javac-timeout

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Dec 19, 2023

Unclean backport to improve build reliability. Affected file was moved in JDK 20 with large refactoring, JDK-8297444. I had to re-apply the patch by hand.

Additional testing:

  • Local macos-aarch64-server-fastdebug build
  • GHA

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8318961 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8318961: increase javacserver connection timeout values and max retry attempts (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2063/head:pull/2063
$ git checkout pull/2063

Update a local copy of the PR:
$ git checkout pull/2063
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2063/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2063

View PR using the GUI difftool:
$ git pr show -t 2063

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2063.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 19, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b9983c72295a31e5f5079bc96c892177fbea3a6e 8318961: increase javacserver connection timeout values and max retry attempts Dec 19, 2023
@openjdk
Copy link

openjdk bot commented Dec 19, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Dec 19, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 19, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 20, 2023

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@shipilev
Copy link
Member Author

shipilev commented Jan 2, 2024

/approval request Unclean backport to improve build reliability. There were file moves in later JDKs, so I had to reapply patch by hand. Patch acked my Mattias.

@openjdk
Copy link

openjdk bot commented Jan 2, 2024

@shipilev
8318961: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jan 2, 2024
@openjdk
Copy link

openjdk bot commented Jan 3, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318961: increase javacserver connection timeout values and max retry attempts

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 5d86e19: 8320937: support latest VS2022 MSC_VER in abstract_vm_version.cpp
  • 43d15d1: 8307926: Support byte-sized atomic bitset operations

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jan 3, 2024
@shipilev
Copy link
Member Author

shipilev commented Jan 3, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jan 3, 2024

Going to push as commit 53211e0.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 5d86e19: 8320937: support latest VS2022 MSC_VER in abstract_vm_version.cpp
  • 43d15d1: 8307926: Support byte-sized atomic bitset operations

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 3, 2024
@openjdk openjdk bot closed this Jan 3, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 3, 2024
@openjdk
Copy link

openjdk bot commented Jan 3, 2024

@shipilev Pushed as commit 53211e0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants