8316679: C2 SuperWord: wrong result, load should not be moved before store if not comparable

[GoeLin]

I backport this for parity with 17.0.11-oracle.

I had to resolve because in the context SWPointer was renamed to VPointer.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8316679 needs maintainer approval

Issue

• JDK-8316679: C2 SuperWord: wrong result, load should not be moved before store if not comparable (Bug - P3 - Approved)

Reviewers

• Roland Westrelin (@rwestrel - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2071/head:pull/2071
$ git checkout pull/2071

Update a local copy of the PR:
$ git checkout pull/2071
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2071/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2071

View PR using the GUI difftool:
$ git pr show -t 2071

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2071.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (876d6a59)

[rwestrel]

Looks good to me.

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[GoeLin]

Thanks for the reviews!

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316679: C2 SuperWord: wrong result, load should not be moved before store if not comparable

Reviewed-by: roland

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• 32fc8a2: 8313816: Accessing jmethodID might lead to spurious crashes
• c55cc97: 8319456: jdk/jfr/event/gc/collection/TestGCCauseWith[Serial|Parallel].java : GC cause 'GCLocker Initiated GC' not in the valid causes
• 8e66afb: 8318689: jtreg is confused when folder name is the same as the test name
• c0b4255: 8305356: Fix ignored bad CompileCommands in tests
• 725f3c0: 8278363: Create extented container test groups
• b6f24f5: 8274621: NullPointerException because listenAddress[0] is null
• 4144ef3: 8318410: jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese Windows

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[GoeLin]

/integrate

[openjdk]

Going to push as commit dd4da3d.
Since your change was applied there have been 10 commits pushed to the master branch:

• 346848d: 8316445: Mark com/sun/management/HotSpotDiagnosticMXBean/CheckOrigin.java as vm.flagless
• a60492e: 8315920: C2: "control input must dominate current control" assert failure
• 9a43e9f: 8321972: test runtime/Unsafe/InternalErrorTest.java timeout on linux-riscv64 platform
• 32fc8a2: 8313816: Accessing jmethodID might lead to spurious crashes
• c55cc97: 8319456: jdk/jfr/event/gc/collection/TestGCCauseWith[Serial|Parallel].java : GC cause 'GCLocker Initiated GC' not in the valid causes
• 8e66afb: 8318689: jtreg is confused when folder name is the same as the test name
• c0b4255: 8305356: Fix ignored bad CompileCommands in tests
• 725f3c0: 8278363: Create extented container test groups
• b6f24f5: 8274621: NullPointerException because listenAddress[0] is null
• 4144ef3: 8318410: jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese Windows

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit dd4da3d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.