Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261837: SIGSEGV in ciVirtualCallTypeData::translate_from #2076

Closed
wants to merge 2 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 21, 2023

I backport this for parity with 17.0.11-oracle.

I had to resolve.

c1_LIRAssembler_x86.cpp becuase of nullptr in context.
interp_masm_x86.cpp because another fix was backported (Register tmp_load_klass = LP64_ONLY(rscratch1) NOT_LP64(noreg);)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8261837 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8261837: SIGSEGV in ciVirtualCallTypeData::translate_from (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2076/head:pull/2076
$ git checkout pull/2076

Update a local copy of the PR:
$ git checkout pull/2076
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2076/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2076

View PR using the GUI difftool:
$ git pr show -t 2076

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2076.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 21, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1bb250c9e6b65d1a7a2b90eeb7d6e3a936fb8e8e 8261837: SIGSEGV in ciVirtualCallTypeData::translate_from Dec 21, 2023
@openjdk
Copy link

openjdk bot commented Dec 21, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 21, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 21, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Dec 21, 2023

/review 1

@openjdk
Copy link

openjdk bot commented Dec 21, 2023

@GoeLin Unknown command review - for a list of valid commands use /help.

@GoeLin
Copy link
Member Author

GoeLin commented Dec 21, 2023

/reviewers 1

@openjdk
Copy link

openjdk bot commented Dec 21, 2023

@GoeLin
Warning: By issuing the /reviewers command in this clean backport pull request, the reviewers check has now been enabled.
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 1 (with at least 1 Reviewer).

@mlbridge
Copy link

mlbridge bot commented Dec 21, 2023

Webrevs

@openjdk openjdk bot removed the clean label Dec 21, 2023
Copy link
Contributor

@rwestrel rwestrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk openjdk bot added the approval label Dec 23, 2023
@openjdk
Copy link

openjdk bot commented Dec 23, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261837: SIGSEGV in ciVirtualCallTypeData::translate_from

Reviewed-by: roland

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • c6841e0: 8318983: Fix comment typo in PKCS12Passwd.java
  • d0eba0d: 8319668: Fixup of jar filename typo in BadFactoryTest.sh
  • c6c4d65: 8316392: compiler/interpreter/TestVerifyStackAfterDeopt.java failed with SIGBUS in PcDescContainer::find_pc_desc_internal
  • dd4da3d: 8316679: C2 SuperWord: wrong result, load should not be moved before store if not comparable
  • 346848d: 8316445: Mark com/sun/management/HotSpotDiagnosticMXBean/CheckOrigin.java as vm.flagless
  • a60492e: 8315920: C2: "control input must dominate current control" assert failure
  • 9a43e9f: 8321972: test runtime/Unsafe/InternalErrorTest.java timeout on linux-riscv64 platform
  • 32fc8a2: 8313816: Accessing jmethodID might lead to spurious crashes
  • c55cc97: 8319456: jdk/jfr/event/gc/collection/TestGCCauseWith[Serial|Parallel].java : GC cause 'GCLocker Initiated GC' not in the valid causes
  • 8e66afb: 8318689: jtreg is confused when folder name is the same as the test name
  • ... and 4 more: https://git.openjdk.org/jdk17u-dev/compare/38036c10466a4a35a2c7437d4b9df849625e7a08...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 23, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Dec 24, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Dec 24, 2023

Going to push as commit 1128de1.
Since your change was applied there have been 14 commits pushed to the master branch:

  • c6841e0: 8318983: Fix comment typo in PKCS12Passwd.java
  • d0eba0d: 8319668: Fixup of jar filename typo in BadFactoryTest.sh
  • c6c4d65: 8316392: compiler/interpreter/TestVerifyStackAfterDeopt.java failed with SIGBUS in PcDescContainer::find_pc_desc_internal
  • dd4da3d: 8316679: C2 SuperWord: wrong result, load should not be moved before store if not comparable
  • 346848d: 8316445: Mark com/sun/management/HotSpotDiagnosticMXBean/CheckOrigin.java as vm.flagless
  • a60492e: 8315920: C2: "control input must dominate current control" assert failure
  • 9a43e9f: 8321972: test runtime/Unsafe/InternalErrorTest.java timeout on linux-riscv64 platform
  • 32fc8a2: 8313816: Accessing jmethodID might lead to spurious crashes
  • c55cc97: 8319456: jdk/jfr/event/gc/collection/TestGCCauseWith[Serial|Parallel].java : GC cause 'GCLocker Initiated GC' not in the valid causes
  • 8e66afb: 8318689: jtreg is confused when folder name is the same as the test name
  • ... and 4 more: https://git.openjdk.org/jdk17u-dev/compare/38036c10466a4a35a2c7437d4b9df849625e7a08...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 24, 2023
@openjdk openjdk bot closed this Dec 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 24, 2023
@openjdk
Copy link

openjdk bot commented Dec 24, 2023

@GoeLin Pushed as commit 1128de1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8261837 branch December 24, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants