-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8321972: test runtime/Unsafe/InternalErrorTest.java timeout on linux-riscv64 platform #2078
Conversation
…on linux-riscv64 platform
👋 Welcome back gcao! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
|
@zifeihan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 101 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
Going to push as commit 9a43e9f.
Your commit was automatically rebased without conflicts. |
@RealFYang @zifeihan Pushed as commit 9a43e9f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi, The same issue also exists in the JDK17U: I can reproduce it locally by applying fix for JDK-8320886 and running test/hotspot/jtreg/runtime/Unsafe/InternalErrorTest.java test. So I would like to backport this to JDK17U. Tier1-3 tested with fastdebug build using qemu systems. This is a risc-v specific change. Backport is clean, risk is low.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2078/head:pull/2078
$ git checkout pull/2078
Update a local copy of the PR:
$ git checkout pull/2078
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2078/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2078
View PR using the GUI difftool:
$ git pr show -t 2078
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2078.diff
Webrev
Link to Webrev Comment