Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318474: Fix memory reporter for thread_count #2085

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zer0chance
Copy link

@zer0chance zer0chance commented Dec 27, 2023


Progress

  • Change must not contain extraneous whitespace
  • JDK-8318474 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8318474: Fix memory reporter for thread_count (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2085/head:pull/2085
$ git checkout pull/2085

Update a local copy of the PR:
$ git checkout pull/2085
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2085/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2085

View PR using the GUI difftool:
$ git pr show -t 2085

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2085.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 27, 2023

👋 Welcome back zer0chance! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0baa9ecd76c9be33a1939e47dcae320bc8b65e96 8318474: Fix memory reporter for thread_count Dec 27, 2023
@openjdk
Copy link

openjdk bot commented Dec 27, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 27, 2023

⚠️ @zer0chance This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 27, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 27, 2023

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 24, 2024

@zer0chance This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@zer0chance
Copy link
Author

Adding comment to keep this PR alive. @GoeLin do I need to do anything else to get your approval on this?
(followup for #2084)

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 12, 2024

@zer0chance This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 10, 2024

@zer0chance This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented May 9, 2024

@zer0chance This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this May 9, 2024
@zer0chance
Copy link
Author

/open

@openjdk openjdk bot reopened this May 23, 2024
@openjdk
Copy link

openjdk bot commented May 23, 2024

@zer0chance This pull request is now open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
1 participant