Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318957: Enhance agentlib:jdwp help output by info about allow option #2086

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Dec 28, 2023


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8318957 needs maintainer approval

Issue

  • JDK-8318957: Enhance agentlib:jdwp help output by info about allow option (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2086/head:pull/2086
$ git checkout pull/2086

Update a local copy of the PR:
$ git checkout pull/2086
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2086/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2086

View PR using the GUI difftool:
$ git pr show -t 2086

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2086.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 28, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 53bb7cd415f1d2e87d8f06ad5eb611bfdf8ef0ad 8318957: Enhance agentlib:jdwp help output by info about allow option Dec 28, 2023
@openjdk
Copy link

openjdk bot commented Dec 28, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 28, 2023

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added rfr Pull request is ready for review approval labels Dec 28, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 28, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 29, 2023

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318957: Enhance agentlib:jdwp help output by info about allow option

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • accaade: 8281377: Remove vmTestbase/nsk/monitoring/ThreadMXBean/ThreadInfo/Deadlock/JavaDeadlock001/TestDescription.java from problemlist.

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 29, 2023
@MBaesken
Copy link
Member Author

MBaesken commented Jan 4, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jan 4, 2024

Going to push as commit bb50eb3.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 73fcc8e: 8322968: [17u] Amend Atomics gtest with 1-byte tests
  • 13ca9b7: 8286312: Stop mixing signed and unsigned types in bit operations
  • 21171d9: 8283626: AArch64: Set relocInfo::offset_unit to 4
  • 3eb15b0: 8205076: [17u] Inet6AddressImpl.c: lookupIfLocalHost accesses int InetAddress.preferIPv6Address as a boolean
  • 2a0d0ac: 8318183: C2: VM may crash after hitting node limit
  • 53211e0: 8318961: increase javacserver connection timeout values and max retry attempts
  • 5d86e19: 8320937: support latest VS2022 MSC_VER in abstract_vm_version.cpp
  • 43d15d1: 8307926: Support byte-sized atomic bitset operations
  • e3faedb: 8316414: C2: large byte array clone triggers "failed: malformed control flow" assertion failure on linux-x86
  • 97f52ed: 8316001: GC: Make TestArrayAllocatorMallocLimit use createTestJvm
  • ... and 3 more: https://git.openjdk.org/jdk17u-dev/compare/f44f2c5e6fd7cff4bd80c1d9e9af1bc9e2017c61...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 4, 2024
@openjdk openjdk bot closed this Jan 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 4, 2024
@openjdk
Copy link

openjdk bot commented Jan 4, 2024

@MBaesken Pushed as commit bb50eb3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant