Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8322772: Clean up code after JDK-8322417 #2090

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Dec 31, 2023

Code cleanup after JDK-8322417


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8322772 needs maintainer approval

Issue

  • JDK-8322772: Clean up code after JDK-8322417 (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2090/head:pull/2090
$ git checkout pull/2090

Update a local copy of the PR:
$ git checkout pull/2090
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2090/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2090

View PR using the GUI difftool:
$ git pr show -t 2090

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2090.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 31, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 24b3b2b66f0bed3e9812999a5b6d511f31e9ad1f 8322772: Clean up code after JDK-8322417 Dec 31, 2023
@openjdk
Copy link

openjdk bot commented Dec 31, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 31, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 31, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 2, 2024

⚠️ @RealCLanger This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Jan 7, 2024
@openjdk
Copy link

openjdk bot commented Jan 8, 2024

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322772: Clean up code after JDK-8322417

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 8, 2024
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

Going to push as commit bfd23ae.
Since your change was applied there have been 19 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 9, 2024
@openjdk openjdk bot closed this Jan 9, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@RealCLanger Pushed as commit bfd23ae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the backport-RealCLanger-24b3b2b6 branch January 9, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants