8322321: Add man page doc for -XX:+VerifySharedSpaces

[jmtd]

This is an unclean backport of a manpage fix, for Oracle parity. The conflict was trivial to resolve manually and was due to the troff source being updated post-17u for 8297164, which is unlikely to be backported itself.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8322321 needs maintainer approval

Issue

• JDK-8322321: Add man page doc for -XX:+VerifySharedSpaces (Enhancement - P4 - Approved)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2098/head:pull/2098
$ git checkout pull/2098

Update a local copy of the PR:
$ git checkout pull/2098
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2098/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2098

View PR using the GUI difftool:
$ git pr show -t 2098

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2098.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jdowland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[jmtd]

/approval request Oracle parity, docs improvement

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @jmtd This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk]

@jmtd
8322321: The approval request has been created successfully.

[mlbridge]

Webrevs

• 00: Full (eb20848f)

[shipilev]

Looks okay.

[jmtd]

/integrate

[openjdk]

@jmtd This pull request has not yet been marked as ready for integration.

[shipilev]

Nope, you now need maintainer approval. My review only covers the "unclean backport" part.

[jmtd]

Nope, you now need maintainer approval. My review only covers the "unclean backport" part.

Gotcha, thanks. I'm somewhat rusty. This is useful grist for the mill.

[GoeLin]

Hi @jmtd
somewhat off-topic: you might want to have a look at "dependent pull requests", i.e. how to stack several PRs.
There is a current example: PRs 105, 129, 130. Have a look at the branch they compare to (openjdkd:pr/129 etc).

[GoeLin]

For this change, you should have a look at the broken GHA tests and tell in the PR what is going on.
From the content of the change it's pretty likely that that is unrelated stuff, but these should be checked by the backporter. I will only approve changes with green GHA tests, or, if red, if the backporter states the that the issues are unrelated to his change.

[GoeLin]

I'll remove the label for now.

[GoeLin]

Hi @jmtd, have you given this up?

[jmtd]

Hi @GoeLin no, I just haven't had a chance to pivot back to backports this week. Sorry! I'll look at it Monday.

[jmtd]

THe GHA test failure macos-x64 (hs/tier1 gc) is unrelated (gc/logging/TestMetaSpaceLog.java Error.
Agent error: java.lang.Exception: Agent 7 timed out with a timeout of 480
seconds; check console log for any additional details).

[jmtd]

/approval request Oracle parity, docs improvement. GHA test failure (macos-x64 hs/tier1 gc) unrelated. TIA!

[openjdk]

@jmtd
8322321: The approval request has been updated successfully.

[GoeLin]

Thanks!

[openjdk]

@jmtd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322321: Add man page doc for -XX:+VerifySharedSpaces

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 46 new commits pushed to the master branch:

• a6135d7: 8169475: WheelModifier.java fails by timeout
• 6b5655a: 8319124: Update XML Security for Java to 3.0.3
• e113ab7: 8317771: [macos14] Expand/collapse a JTree using keyboard freezes the application in macOS 14 Sonoma
• a632e30: 8323008: filter out harmful -std* flags added by autoconf from CXX
• 6513d23: 8320300: Adjust hs_err output in malloc/mmap error cases
• 769708f: 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files
• 347ee0f: 8310631: test/jdk/sun/nio/cs/TestCharsetMapping.java is spuriously passing
• ddd5f21: 8311986: Disable runtime/os/TestTracePageSizes.java for ShenandoahGC
• 381d90b: 8323806: [17u] VS2017 build fails with warning after 8293117.
• f133108: 8305972: Update XML Security for Java to 3.0.2
• ... and 36 more: https://git.openjdk.org/jdk17u-dev/compare/73fcc8ea23689f1f7970b2a1a36be2528cc6a5b6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jmtd]

/integrate

[openjdk]

Going to push as commit 1425971.
Since your change was applied there have been 54 commits pushed to the master branch:

• 5b2aec6: 8318490: Increase timeout for JDK tests that are close to the limit when run with libgraal
• 67aa1de: 8319213: Compatibility.java reads both stdout and stderr of JdkUtils
• b4f1deb: 8312428: PKCS11 tests fail with NSS 3.91
• b186446: 8317039: Enable specifying the JDK used to run jtreg
• 7c4aaec: 8313206: PKCS11 tests silently skip execution
• 391bd2d: 8309305: sun/security/ssl/SSLSocketImpl/BlockedAsyncClose.java fails with jtreg test timeout
• e9ddb51: 8311581: Remove obsolete code and comments in TestLVT.java
• 8162425: 8307955: Prefer to PTRACE_GETREGSET instead of PTRACE_GETREGS in method 'ps_proc.c::process_get_lwp_regs'
• a6135d7: 8169475: WheelModifier.java fails by timeout
• 6b5655a: 8319124: Update XML Security for Java to 3.0.3
• ... and 44 more: https://git.openjdk.org/jdk17u-dev/compare/73fcc8ea23689f1f7970b2a1a36be2528cc6a5b6...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jmtd Pushed as commit 1425971.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.