Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277072: ObjectStreamClass caches keep ClassLoaders alive #210

Closed

Conversation

rkennke
Copy link
Contributor

@rkennke rkennke commented Mar 9, 2022

Hi all,

This pull request contains a backport of commit 8eb453ba from the openjdk/jdk repository.

The commit being backported was authored by Roman Kennke on 10 Dec 2021 and was reviewed by Roger Riggs and Peter Levart.

It fixes a memory leak in ObjectStreamClass under certain conditions. See bug for details.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8277072: ObjectStreamClass caches keep ClassLoaders alive

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/210/head:pull/210
$ git checkout pull/210

Update a local copy of the PR:
$ git checkout pull/210
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/210/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 210

View PR using the GUI difftool:
$ git pr show -t 210

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/210.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 9, 2022

👋 Welcome back rkennke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8eb453baebe377697286f7eb32280ca9f1fd7775 8277072: ObjectStreamClass caches keep ClassLoaders alive Mar 9, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Mar 9, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 9, 2022

@rkennke This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277072: ObjectStreamClass caches keep ClassLoaders alive

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Mar 9, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 9, 2022

Webrevs

@rkennke
Copy link
Contributor Author

@rkennke rkennke commented Mar 25, 2022

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Mar 25, 2022

Going to push as commit 7d132f5.
Since your change was applied there have been 75 commits pushed to the master branch:

  • ba6f733: 8255266: Update Public Suffix List to 3c213aa
  • 3c123f3: 8282444: Module finder incorrectly assumes default file system path-separator character
  • 13140f9: 8281266: [JVMCI] MetaUtil.toInternalName() doesn't handle hidden classes correctly
  • 1705541: 8281338: NSAccessibilityPressAction action for tree node and NSAccessibilityShowMenuAcgtion action not working
  • d62a116: Merge
  • c3ea7ca: 8282761: XPathFactoryImpl remove setProperty and getProperty methods
  • 18ece9b: 8282345: handle latest VS2022 in abstract_vm_version
  • d442446: 8281274: deal with ActiveProcessorCount in os::Linux::print_container_info
  • d6eb281: 8280543: Update the "java" and "jcmd" tool specification for CDS
  • d19ec6f: 8193682: Infinite loop in ZipOutputStream.close()
  • ... and 65 more: https://git.openjdk.java.net/jdk17u-dev/compare/11a5bbd65ef39d500fd90a7032e96055333a5a0d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Mar 25, 2022
@openjdk openjdk bot closed this Mar 25, 2022
@openjdk openjdk bot removed ready rfr labels Mar 25, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Mar 25, 2022

@rkennke Pushed as commit 7d132f5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant