Skip to content

8322725: (tz) Update Timezone Data to 2023d#2104

Closed
lutkerd wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-lutkerd-2a9c3589
Closed

8322725: (tz) Update Timezone Data to 2023d#2104
lutkerd wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-lutkerd-2a9c3589

Conversation

@lutkerd
Copy link
Contributor

@lutkerd lutkerd commented Jan 5, 2024

Clean backport of tzdata2023d


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8322725 needs maintainer approval

Issue

  • JDK-8322725: (tz) Update Timezone Data to 2023d (Enhancement - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2104/head:pull/2104
$ git checkout pull/2104

Update a local copy of the PR:
$ git checkout pull/2104
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2104/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2104

View PR using the GUI difftool:
$ git pr show -t 2104

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2104.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 5, 2024

👋 Welcome back dlutker! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2a9c3589d941d9a57e536ea0b3d7919c6ddb82dc 8322725: (tz) Update Timezone Data to 2023d Jan 5, 2024
@openjdk
Copy link

openjdk bot commented Jan 5, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Jan 5, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 5, 2024

Webrevs

@lutkerd
Copy link
Contributor Author

lutkerd commented Jan 8, 2024

/clean was clean backport done via PR command.

@openjdk
Copy link

openjdk bot commented Jan 8, 2024

@lutkerd Only OpenJDK Committers can use the /clean command

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is apparently the automatic /backport, but it is not marked clean, because the paths are different. Bots seemed to have auto-detected the moves correctly, and then correctly implicitly asked for reviews. Good bots.

I checked the change against the mainline commit (openjdk/jdk@2a9c358) and previous commit to jdk17u-dev (openjdk/jdk17u@f8408c7), and I think this is a correct thing to do.

@openjdk
Copy link

openjdk bot commented Jan 8, 2024

⚠️ @lutkerd This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@lutkerd
Copy link
Contributor Author

lutkerd commented Jan 8, 2024

/approval request backport of tzdata2023d. Local tests pass

@openjdk
Copy link

openjdk bot commented Jan 8, 2024

@lutkerd
8322725: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jan 8, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@lutkerd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322725: (tz) Update Timezone Data to 2023d

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 002270c: 8323021: Shenandoah: Encountered reference count always attributed to first worker thread
  • bfd23ae: 8322772: Clean up code after JDK-8322417
  • 1f95796: 8321599: Data loss in AVX3 Base64 decoding
  • 2470cac: 8316693: Simplify at-requires checkDockerSupport()
  • f59ca35: 8303605: Memory leaks in Metaspace gtests
  • f001819: 8322985: [BACKOUT] 8318562: Computational test more than 2x slower when AVX instructions are used
  • dff69b7: 8278028: [test-library] Warnings cleanup of the test library

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jan 9, 2024
@lutkerd
Copy link
Contributor Author

lutkerd commented Jan 9, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@lutkerd
Your change (at version 479af7a) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

shipilev commented Jan 9, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

Going to push as commit 26b5597.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 002270c: 8323021: Shenandoah: Encountered reference count always attributed to first worker thread
  • bfd23ae: 8322772: Clean up code after JDK-8322417
  • 1f95796: 8321599: Data loss in AVX3 Base64 decoding
  • 2470cac: 8316693: Simplify at-requires checkDockerSupport()
  • f59ca35: 8303605: Memory leaks in Metaspace gtests
  • f001819: 8322985: [BACKOUT] 8318562: Computational test more than 2x slower when AVX instructions are used
  • dff69b7: 8278028: [test-library] Warnings cleanup of the test library

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 9, 2024
@openjdk openjdk bot closed this Jan 9, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@shipilev @lutkerd Pushed as commit 26b5597.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants