Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8323021: Shenandoah: Encountered reference count always attributed to first worker thread #2105

Conversation

earthling-amzn
Copy link

@earthling-amzn earthling-amzn commented Jan 5, 2024


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8323021 needs maintainer approval

Issue

  • JDK-8323021: Shenandoah: Encountered reference count always attributed to first worker thread (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2105/head:pull/2105
$ git checkout pull/2105

Update a local copy of the PR:
$ git checkout pull/2105
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2105/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2105

View PR using the GUI difftool:
$ git pr show -t 2105

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2105.diff

Webrev

Link to Webrev Comment

… first worker thread

Reviewed-by: kdnilsen, ysr, shade
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 5, 2024

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f0e2e4311b8cab160dc9e35f43e9ae5a145c5e23 8323021: Shenandoah: Encountered reference count always attributed to first worker thread Jan 5, 2024
@openjdk
Copy link

openjdk bot commented Jan 5, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 5, 2024

⚠️ @earthling-amzn This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval rfr Pull request is ready for review labels Jan 5, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 5, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 6, 2024

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323021: Shenandoah: Encountered reference count always attributed to first worker thread

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 1f95796: 8321599: Data loss in AVX3 Base64 decoding
  • 2470cac: 8316693: Simplify at-requires checkDockerSupport()
  • f59ca35: 8303605: Memory leaks in Metaspace gtests
  • f001819: 8322985: [BACKOUT] 8318562: Computational test more than 2x slower when AVX instructions are used
  • dff69b7: 8278028: [test-library] Warnings cleanup of the test library

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 6, 2024
@earthling-amzn
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 8, 2024
@openjdk
Copy link

openjdk bot commented Jan 8, 2024

@earthling-amzn
Your change (at version 7ced3db) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

shipilev commented Jan 9, 2024

/sponsor

1 similar comment
@shipilev
Copy link
Member

shipilev commented Jan 9, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

Going to push as commit 002270c.
Since your change was applied there have been 6 commits pushed to the master branch:

  • bfd23ae: 8322772: Clean up code after JDK-8322417
  • 1f95796: 8321599: Data loss in AVX3 Base64 decoding
  • 2470cac: 8316693: Simplify at-requires checkDockerSupport()
  • f59ca35: 8303605: Memory leaks in Metaspace gtests
  • f001819: 8322985: [BACKOUT] 8318562: Computational test more than 2x slower when AVX instructions are used
  • dff69b7: 8278028: [test-library] Warnings cleanup of the test library

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 9, 2024
@openjdk openjdk bot closed this Jan 9, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@shipilev @earthling-amzn Pushed as commit 002270c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented Jan 9, 2024

@shipilev The command sponsor can only be used in open pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants