Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8323210: Update the usage of cmsFLAGS_COPY_ALPHA #2118

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jan 10, 2024

Hi all,

This pull request contains a backport of commit openjdk/jdk@aba1933 from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 9 Jan 2024 and was reviewed by Philip Race.

The patch is functionally the same but different in context due to the next patch is missing in 17:
https://bugs.openjdk.org/browse/JDK-8294488 I do not plan to backport that cleanup

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8323210 needs maintainer approval

Issue

  • JDK-8323210: Update the usage of cmsFLAGS_COPY_ALPHA (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2118/head:pull/2118
$ git checkout pull/2118

Update a local copy of the PR:
$ git checkout pull/2118
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2118/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2118

View PR using the GUI difftool:
$ git pr show -t 2118

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2118.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 10, 2024

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport aba19334eaeb46d37169cddeef929b13e050a60e 8323210: Update the usage of cmsFLAGS_COPY_ALPHA Jan 10, 2024
@openjdk
Copy link

openjdk bot commented Jan 10, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Jan 10, 2024
@mrserb mrserb marked this pull request as ready for review January 10, 2024 03:21
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 10, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 10, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 11, 2024

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval and removed approval labels Jan 15, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 9, 2024

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@mrserb
Copy link
Member Author

mrserb commented Feb 12, 2024

keep open

@openjdk openjdk bot added the approval label Feb 29, 2024
@openjdk
Copy link

openjdk bot commented Mar 1, 2024

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323210: Update the usage of cmsFLAGS_COPY_ALPHA

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 120 new commits pushed to the master branch:

  • 85a49ed: 8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name
  • 2b34eeb: 8325496: Make TrimNativeHeapInterval a product switch
  • 5687c5a: 8325213: Flags introduced by configure script are not passed to ADLC build
  • 204ec8a: 8323717: Introduce test keyword for tests that need external dependencies
  • 87e7c6e: 8326942: [17u] Backout "8325254: CKA_TOKEN private and secret keys are not necessarily sensitive"
  • 8c3dcf3: 8324050: Issue store-store barrier after re-materializing objects during deoptimization
  • 4b0a015: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16
  • f9a33da: 8294156: Allow PassFailJFrame.Builder to create test UI
  • c4a92c5: 8316053: Open some swing tests 3
  • 31d16a1: 8315726: Open source several AWT applet tests
  • ... and 110 more: https://git.openjdk.org/jdk17u-dev/compare/092758703e25644cc6f867ec8a4fbd4e23e8cd3a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 1, 2024
@mrserb
Copy link
Member Author

mrserb commented Mar 2, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Mar 2, 2024

Going to push as commit ab602af.
Since your change was applied there have been 121 commits pushed to the master branch:

  • 0052ab7: 8269914: Factor out heap printing for G1 young and full gc
  • 85a49ed: 8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name
  • 2b34eeb: 8325496: Make TrimNativeHeapInterval a product switch
  • 5687c5a: 8325213: Flags introduced by configure script are not passed to ADLC build
  • 204ec8a: 8323717: Introduce test keyword for tests that need external dependencies
  • 87e7c6e: 8326942: [17u] Backout "8325254: CKA_TOKEN private and secret keys are not necessarily sensitive"
  • 8c3dcf3: 8324050: Issue store-store barrier after re-materializing objects during deoptimization
  • 4b0a015: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16
  • f9a33da: 8294156: Allow PassFailJFrame.Builder to create test UI
  • c4a92c5: 8316053: Open some swing tests 3
  • ... and 111 more: https://git.openjdk.org/jdk17u-dev/compare/092758703e25644cc6f867ec8a4fbd4e23e8cd3a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 2, 2024
@openjdk openjdk bot closed this Mar 2, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 2, 2024
@openjdk
Copy link

openjdk bot commented Mar 2, 2024

@mrserb Pushed as commit ab602af.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the backport-mrserb-aba19334 branch March 2, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants