8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader

[benty-amzn]

Clean backport of JDK-8319436 to resolve a regression introduced in 17.0.8. Included tests pass locally on linux x64.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8319436 needs maintainer approval

Issue

• JDK-8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2119/head:pull/2119
$ git checkout pull/2119

Update a local copy of the PR:
$ git checkout pull/2119
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2119/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2119

View PR using the GUI difftool:
$ git pr show -t 2119

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2119.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back btaylor! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @benty-amzn This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (d39faf47)

[GoeLin]

Please only label fix-request after passing GHA tests! I'll remove the label in the meantime.

[openjdk]

@benty-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

• a6135d7: 8169475: WheelModifier.java fails by timeout
• 6b5655a: 8319124: Update XML Security for Java to 3.0.3
• e113ab7: 8317771: [macos14] Expand/collapse a JTree using keyboard freezes the application in macOS 14 Sonoma
• a632e30: 8323008: filter out harmful -std* flags added by autoconf from CXX
• 6513d23: 8320300: Adjust hs_err output in malloc/mmap error cases
• 769708f: 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files
• 347ee0f: 8310631: test/jdk/sun/nio/cs/TestCharsetMapping.java is spuriously passing
• ddd5f21: 8311986: Disable runtime/os/TestTracePageSizes.java for ShenandoahGC
• 381d90b: 8323806: [17u] VS2017 build fails with warning after 8293117.
• f133108: 8305972: Update XML Security for Java to 3.0.2
• ... and 18 more: https://git.openjdk.org/jdk17u-dev/compare/f194105b29d674be11bdcf02b7e8ee702228ee32...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[benty-amzn]

/integrate

[openjdk]

Going to push as commit cac0e96.
Since your change was applied there have been 37 commits pushed to the master branch:

• 1425971: 8322321: Add man page doc for -XX:+VerifySharedSpaces
• 5b2aec6: 8318490: Increase timeout for JDK tests that are close to the limit when run with libgraal
• 67aa1de: 8319213: Compatibility.java reads both stdout and stderr of JdkUtils
• b4f1deb: 8312428: PKCS11 tests fail with NSS 3.91
• b186446: 8317039: Enable specifying the JDK used to run jtreg
• 7c4aaec: 8313206: PKCS11 tests silently skip execution
• 391bd2d: 8309305: sun/security/ssl/SSLSocketImpl/BlockedAsyncClose.java fails with jtreg test timeout
• e9ddb51: 8311581: Remove obsolete code and comments in TestLVT.java
• 8162425: 8307955: Prefer to PTRACE_GETREGSET instead of PTRACE_GETREGS in method 'ps_proc.c::process_get_lwp_regs'
• a6135d7: 8169475: WheelModifier.java fails by timeout
• ... and 27 more: https://git.openjdk.org/jdk17u-dev/compare/f194105b29d674be11bdcf02b7e8ee702228ee32...master

Your commit was automatically rebased without conflicts.

[openjdk]

@benty-amzn Pushed as commit cac0e96.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.