Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317804: com/sun/jdi/JdwpAllowTest.java fails on Alpine 3.17 / 3.18 #2132

Closed
wants to merge 1 commit into from

Conversation

xiaotaonan
Copy link

@xiaotaonan xiaotaonan commented Jan 16, 2024

Backport-Fix the JdwpAllowTest.java test exception issue.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8317804 needs maintainer approval

Issue

  • JDK-8317804: com/sun/jdi/JdwpAllowTest.java fails on Alpine 3.17 / 3.18 (Bug - P4) ⚠️ Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit. See Backports.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2132/head:pull/2132
$ git checkout pull/2132

Update a local copy of the PR:
$ git checkout pull/2132
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2132/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2132

View PR using the GUI difftool:
$ git pr show -t 2132

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2132.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 16, 2024

👋 Welcome back xiaotaonan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 16, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 16, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 23, 2024

⚠️ @xiaotaonan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@MBaesken
Copy link
Member

Hi @xiaotaonan , there was a jcheck message about a wrong commit message ("The commit message does not reference any issue."); did you adjust this already , now it looks correct to me ?

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 20, 2024

@xiaotaonan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@xiaotaonan xiaotaonan closed this Feb 27, 2024
@xiaotaonan xiaotaonan deleted the JDK-8317804 branch February 27, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants