Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8318490: Increase timeout for JDK tests that are close to the limit when run with libgraal #2147

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 19, 2024

I backport this for parity with 17.0.11-oracle.

Some tests are not in 17, skipped.
All the other are clean.

Will mark as clean.


Progress

  • JDK-8318490 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8318490: Increase timeout for JDK tests that are close to the limit when run with libgraal (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2147/head:pull/2147
$ git checkout pull/2147

Update a local copy of the PR:
$ git checkout pull/2147
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2147/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2147

View PR using the GUI difftool:
$ git pr show -t 2147

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2147.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 19, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6f263111a1812873291e91870e341ccce804d049 8318490: Increase timeout for JDK tests that are close to the limit when run with libgraal Jan 19, 2024
@openjdk
Copy link

openjdk bot commented Jan 19, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jan 19, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 19, 2024

Webrevs

@openjdk openjdk bot added the approval label Jan 22, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Jan 22, 2024

/clean

@openjdk openjdk bot added the clean label Jan 22, 2024
@openjdk
Copy link

openjdk bot commented Jan 22, 2024

@GoeLin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Jan 22, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Jan 22, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318490: Increase timeout for JDK tests that are close to the limit when run with libgraal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • a6135d7: 8169475: WheelModifier.java fails by timeout
  • 6b5655a: 8319124: Update XML Security for Java to 3.0.3

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 22, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Jan 23, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jan 23, 2024

Going to push as commit 5b2aec6.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 67aa1de: 8319213: Compatibility.java reads both stdout and stderr of JdkUtils
  • b4f1deb: 8312428: PKCS11 tests fail with NSS 3.91
  • b186446: 8317039: Enable specifying the JDK used to run jtreg
  • 7c4aaec: 8313206: PKCS11 tests silently skip execution
  • 391bd2d: 8309305: sun/security/ssl/SSLSocketImpl/BlockedAsyncClose.java fails with jtreg test timeout
  • e9ddb51: 8311581: Remove obsolete code and comments in TestLVT.java
  • 8162425: 8307955: Prefer to PTRACE_GETREGSET instead of PTRACE_GETREGS in method 'ps_proc.c::process_get_lwp_regs'
  • a6135d7: 8169475: WheelModifier.java fails by timeout
  • 6b5655a: 8319124: Update XML Security for Java to 3.0.3

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 23, 2024
@openjdk openjdk bot closed this Jan 23, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 23, 2024
@GoeLin GoeLin deleted the goetz_backport_8318490 branch January 23, 2024 08:45
@openjdk
Copy link

openjdk bot commented Jan 23, 2024

@GoeLin Pushed as commit 5b2aec6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant