Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8281585: Remove unused imports under test/lib and jtreg/gc #2154

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 22, 2024

I backport this for parity with 17.0.11-oracle.

Some simple resolves were needed:
test/hotspot/jtreg/gc/arguments/TestArrayAllocatorMallocLimit.java
Copyright.

test/hotspot/jtreg/gc/arguments/TestG1HeapRegionSize.java
Resolved import.

test/hotspot/jtreg/gc/arguments/TestG1RemSetFlags.java
Not in 17.

test/hotspot/jtreg/gc/arguments/TestVerifyBeforeAndAfterGCFlags.java
Copyright and imports due to context.

test/hotspot/jtreg/gc/g1/TestEvacuationFailure.java
Test not in 17.

test/hotspot/jtreg/gc/g1/TestSkipRebuildRemsetPhase.java
Resulved imports due to differences in context.

test/lib/jdk/test/lib/hprof/model/JavaValueArray.java
Copyright


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8281585 needs maintainer approval

Issue

  • JDK-8281585: Remove unused imports under test/lib and jtreg/gc (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2154/head:pull/2154
$ git checkout pull/2154

Update a local copy of the PR:
$ git checkout pull/2154
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2154/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2154

View PR using the GUI difftool:
$ git pr show -t 2154

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2154.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 22, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2604a88fbb6d0f9aec51c7d607ea275bc34a672c 8281585: Remove unused imports under test/lib and jtreg/gc Jan 22, 2024
@openjdk
Copy link

openjdk bot commented Jan 22, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jan 22, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 22, 2024

Webrevs

Copy link

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Ready to integrate if the SAP-internal testing does not reveal any related errors.

@openjdk
Copy link

openjdk bot commented Jan 24, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Jan 24, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Jan 24, 2024

Thanks for the review!

@openjdk
Copy link

openjdk bot commented Jan 24, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281585: Remove unused imports under test/lib and jtreg/gc

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • c774469: 8272811: Document the effects of building with _GNU_SOURCE in os_posix.hpp
  • 5a8af23: 8281543: Remove unused code/headerfile dtraceAttacher.hpp
  • ab3d1d0: 8323243: JNI invocation of an abstract instance method corrupts the stack
  • cac0e96: 8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader
  • 1425971: 8322321: Add man page doc for -XX:+VerifySharedSpaces
  • 5b2aec6: 8318490: Increase timeout for JDK tests that are close to the limit when run with libgraal
  • 67aa1de: 8319213: Compatibility.java reads both stdout and stderr of JdkUtils
  • b4f1deb: 8312428: PKCS11 tests fail with NSS 3.91
  • b186446: 8317039: Enable specifying the JDK used to run jtreg
  • 7c4aaec: 8313206: PKCS11 tests silently skip execution
  • ... and 3 more: https://git.openjdk.org/jdk17u-dev/compare/a6135d783d49dc8047375f62bd969b0874a21891...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 24, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Jan 25, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jan 25, 2024

Going to push as commit 6437792.
Since your change was applied there have been 17 commits pushed to the master branch:

  • 29044ee: 8310238: [test bug] javax/swing/JTableHeader/6889007/bug6889007.java fails
  • 561f956: 8308245: Add -proc:full to describe current default annotation processing policy
  • cb3bd49: 8323086: Shenandoah: Heap could be corrupted by oom during evacuation
  • 4f80edf: 8324184: Windows VS2010 build failed with "error C2275: 'int64_t'"
  • c774469: 8272811: Document the effects of building with _GNU_SOURCE in os_posix.hpp
  • 5a8af23: 8281543: Remove unused code/headerfile dtraceAttacher.hpp
  • ab3d1d0: 8323243: JNI invocation of an abstract instance method corrupts the stack
  • cac0e96: 8319436: Proxy.newProxyInstance throws NPE if loader is null and interface not visible from class loader
  • 1425971: 8322321: Add man page doc for -XX:+VerifySharedSpaces
  • 5b2aec6: 8318490: Increase timeout for JDK tests that are close to the limit when run with libgraal
  • ... and 7 more: https://git.openjdk.org/jdk17u-dev/compare/a6135d783d49dc8047375f62bd969b0874a21891...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 25, 2024
@openjdk openjdk bot closed this Jan 25, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 25, 2024
@openjdk
Copy link

openjdk bot commented Jan 25, 2024

@GoeLin Pushed as commit 6437792.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8281585 branch January 25, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants