-
Notifications
You must be signed in to change notification settings - Fork 232
8281585: Remove unused imports under test/lib and jtreg/gc #2154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
RealLucy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Ready to integrate if the SAP-internal testing does not reveal any related errors.
|
|
|
Thanks for the review! |
|
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 13 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit 6437792.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 17.0.11-oracle.
Some simple resolves were needed:
test/hotspot/jtreg/gc/arguments/TestArrayAllocatorMallocLimit.java
Copyright.
test/hotspot/jtreg/gc/arguments/TestG1HeapRegionSize.java
Resolved import.
test/hotspot/jtreg/gc/arguments/TestG1RemSetFlags.java
Not in 17.
test/hotspot/jtreg/gc/arguments/TestVerifyBeforeAndAfterGCFlags.java
Copyright and imports due to context.
test/hotspot/jtreg/gc/g1/TestEvacuationFailure.java
Test not in 17.
test/hotspot/jtreg/gc/g1/TestSkipRebuildRemsetPhase.java
Resulved imports due to differences in context.
test/lib/jdk/test/lib/hprof/model/JavaValueArray.java
Copyright
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2154/head:pull/2154$ git checkout pull/2154Update a local copy of the PR:
$ git checkout pull/2154$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2154/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2154View PR using the GUI difftool:
$ git pr show -t 2154Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2154.diff
Webrev
Link to Webrev Comment