Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316106: Open source few swing JInternalFrame and JMenuBar tests #2167

Closed
wants to merge 1 commit into from

Conversation

amosshi
Copy link
Contributor

@amosshi amosshi commented Jan 23, 2024

Backport of JDK-8316106

Testing

  • Local: Test passed on MacOS M1 Laptop
    • bug4268949.java - Test results: passed: 1
    • bug4309079.java - Test results: passed: 1
    • bug4732229.java - Test results: passed: 1
    • bug5009724.java - Test results: no tests selected
    • bug4191374.java - Test results: passed: 1
  • Pipeline: All checks have passed
  • Testing Machine: SAP nightlies passed on 2024-01-25,26

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8316106 needs maintainer approval

Issue

  • JDK-8316106: Open source few swing JInternalFrame and JMenuBar tests (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2167/head:pull/2167
$ git checkout pull/2167

Update a local copy of the PR:
$ git checkout pull/2167
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2167/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2167

View PR using the GUI difftool:
$ git pr show -t 2167

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2167.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 23, 2024

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0775bf2f0375b1bc63c187399cbc3fdc5a192bce 8316106: Open source few swing JInternalFrame and JMenuBar tests Jan 23, 2024
@openjdk
Copy link

openjdk bot commented Jan 23, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 23, 2024

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 23, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 23, 2024

Webrevs

@amosshi
Copy link
Contributor Author

amosshi commented Jan 26, 2024

/approval request “Backporting for parity with jdk 17.0.11-oracle. No risk, test fix. Clean backport. SAP nightlies passed on 2024-01-25,26”

@openjdk
Copy link

openjdk bot commented Jan 26, 2024

@amosshi
8316106: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jan 26, 2024
@GoeLin
Copy link
Member

GoeLin commented Jan 29, 2024

I ran bug5009724 on linux. Passes.

@openjdk
Copy link

openjdk bot commented Jan 29, 2024

@amosshi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316106: Open source few swing JInternalFrame and JMenuBar tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

  • 0cdc070: 8319922: libCreationTimeHelper.so fails to link in JDK 21
  • d7c67fc: 8261404: Class.getReflectionFactory() is not thread-safe
  • 3432698: 8324280: RISC-V: Incorrect implementation in VM_Version::parse_satp_mode
  • 184fac8: 8316304: (fs) Add support for BasicFileAttributes.creationTime() for Linux
  • 9926d7c: 8324659: GHA: Generic jtreg errors are not reported
  • 6d8febb: 8309870: Using -proc:full should be considered requesting explicit annotation processing
  • 8fffc07: 8315761: Open source few swing JList and JMenuBar tests
  • f248ea8: 8318608: Enable parallelism in vmTestbase/nsk/stress/threads tests
  • 86df8c2: 8296631: NSS tests failing on OL9 linux-aarch64 hosts
  • 3be0729: 8316947: Write a test to check textArea triggers MouseEntered/MouseExited events properly
  • ... and 21 more: https://git.openjdk.org/jdk17u-dev/compare/a6135d783d49dc8047375f62bd969b0874a21891...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 29, 2024
@amosshi
Copy link
Contributor Author

amosshi commented Jan 29, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 29, 2024
@openjdk
Copy link

openjdk bot commented Jan 29, 2024

@amosshi
Your change (at version 0c9874b) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 30, 2024

Going to push as commit 0e640dc.
Since your change was applied there have been 31 commits pushed to the master branch:

  • 0cdc070: 8319922: libCreationTimeHelper.so fails to link in JDK 21
  • d7c67fc: 8261404: Class.getReflectionFactory() is not thread-safe
  • 3432698: 8324280: RISC-V: Incorrect implementation in VM_Version::parse_satp_mode
  • 184fac8: 8316304: (fs) Add support for BasicFileAttributes.creationTime() for Linux
  • 9926d7c: 8324659: GHA: Generic jtreg errors are not reported
  • 6d8febb: 8309870: Using -proc:full should be considered requesting explicit annotation processing
  • 8fffc07: 8315761: Open source few swing JList and JMenuBar tests
  • f248ea8: 8318608: Enable parallelism in vmTestbase/nsk/stress/threads tests
  • 86df8c2: 8296631: NSS tests failing on OL9 linux-aarch64 hosts
  • 3be0729: 8316947: Write a test to check textArea triggers MouseEntered/MouseExited events properly
  • ... and 21 more: https://git.openjdk.org/jdk17u-dev/compare/a6135d783d49dc8047375f62bd969b0874a21891...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 30, 2024
@openjdk openjdk bot closed this Jan 30, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 30, 2024
@openjdk
Copy link

openjdk bot commented Jan 30, 2024

@shipilev @amosshi Pushed as commit 0e640dc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@amosshi amosshi deleted the backport-8316106 branch February 1, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants