-
Notifications
You must be signed in to change notification settings - Fork 224
8310923: Refactor Currency tests to use JUnit #2174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
/issue add JDK-8321480 |
@luchenlin |
|
Hi @luchenlin , |
Ill remove the tags in the meantime. |
I backport this for parity with 17.0.11-oracle.
Backport for JDK-8321480 and JDK-8310923, JDK-8321480 depends on JDK-8310923,
all clean except: src/java.base/share/data/currency/CurrencyData.properties file path has been changed, backport to the origin file
All Locale constructors change to new Locale("", country) due to JDK-8283698 has not been backported.
Local test pass.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2174/head:pull/2174
$ git checkout pull/2174
Update a local copy of the PR:
$ git checkout pull/2174
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2174/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2174
View PR using the GUI difftool:
$ git pr show -t 2174
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2174.diff
Webrev
Link to Webrev Comment