Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8310923: Refactor Currency tests to use JUnit #2174

Closed
wants to merge 3 commits into from

Conversation

luchenlin
Copy link

@luchenlin luchenlin commented Jan 25, 2024

I backport this for parity with 17.0.11-oracle.
Backport for JDK-8321480 and JDK-8310923, JDK-8321480 depends on JDK-8310923,
all clean except: src/java.base/share/data/currency/CurrencyData.properties file path has been changed, backport to the origin file
All Locale constructors change to new Locale("", country) due to JDK-8283698 has not been backported.
Local test pass.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8321480 needs maintainer approval
  • JDK-8310923 needs maintainer approval

Issues

  • JDK-8310923: Refactor Currency tests to use JUnit (Sub-task - P4)
  • JDK-8321480: ISO 4217 Amendment 176 Update (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2174/head:pull/2174
$ git checkout pull/2174

Update a local copy of the PR:
$ git checkout pull/2174
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2174/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2174

View PR using the GUI difftool:
$ git pr show -t 2174

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2174.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 25, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e848d9471f5de86e5ac157b710cd7371f12f0024 8310923: Refactor Currency tests to use JUnit Jan 25, 2024
@openjdk
Copy link

openjdk bot commented Jan 25, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jan 25, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 25, 2024

Webrevs

@luchenlin
Copy link
Author

/issue add JDK-8321480

@openjdk
Copy link

openjdk bot commented Jan 25, 2024

@luchenlin
Adding additional issue to issue list: 8321480: ISO 4217 Amendment 176 Update.

@openjdk
Copy link

openjdk bot commented Jan 26, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Jan 29, 2024
@GoeLin
Copy link
Member

GoeLin commented Jan 29, 2024

Hi @luchenlin ,
this mingles two quite different changes if I get it right.
The junit refactoring of the currentcy tests, and the ISO 4217 update.
Please make two seperate PRs for these two changes. Thanks.

@GoeLin
Copy link
Member

GoeLin commented Jan 30, 2024

Ill remove the tags in the meantime.

@openjdk openjdk bot removed the approval label Jan 30, 2024
@luchenlin luchenlin closed this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
3 participants