8321815: Shenandoah: gc state should be synchronized to java threads only once per safepoint

[earthling-amzn]

Resolved conflict with unused method

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8321815 needs maintainer approval

Issue

• JDK-8321815: Shenandoah: gc state should be synchronized to java threads only once per safepoint (Enhancement - P4 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2177/head:pull/2177
$ git checkout pull/2177

Update a local copy of the PR:
$ git checkout pull/2177
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2177/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2177

View PR using the GUI difftool:
$ git pr show -t 2177

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2177.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (612d975e)

[openjdk]

⚠️ @earthling-amzn This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[earthling-amzn]

/approval request Conflicts were not difficult to resolve. This change reduces work on the safepoint. We've tested this with Dacapo, Extremem, Heapothesys, SpecJBB2015 and SpecJVM2008.

[openjdk]

@earthling-amzn
8321815: The approval request has been created successfully.

[GoeLin]

/approve yes

[openjdk]

@GoeLin
8321815: The approval request has been approved.

[openjdk]

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321815: Shenandoah: gc state should be synchronized to java threads only once per safepoint

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

• 0790496: 8317144: Exclude sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java on Linux ppc64le
• 2500dbe: 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id
• 43049fd: 8209595: MonitorVmStartTerminate.java timed out
• 50222fc: 8311081: KeytoolReaderP12Test.java fail on localized Windows platform
• 0eb3344: 8310807: java/nio/channels/DatagramChannel/Connect.java timed out
• 8fbdb41: 8315600: Open source few more headless Swing misc tests
• f1a41e2: 8315986: [macos14] javax/swing/JMenuItem/4654927/bug4654927.java: component must be showing on the screen to determine its location
• 0e640dc: 8316106: Open source few swing JInternalFrame and JMenuBar tests
• 0cdc070: 8319922: libCreationTimeHelper.so fails to link in JDK 21
• d7c67fc: 8261404: Class.getReflectionFactory() is not thread-safe
• ... and 8 more: https://git.openjdk.org/jdk17u-dev/compare/8e50363853decbb86607f2bcb1a4e8cb9fc284a4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[earthling-amzn]

/integrate

[openjdk]

@earthling-amzn
Your change (at version 612d975) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 5e8883e.
Since your change was applied there have been 18 commits pushed to the master branch:

• 0790496: 8317144: Exclude sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java on Linux ppc64le
• 2500dbe: 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id
• 43049fd: 8209595: MonitorVmStartTerminate.java timed out
• 50222fc: 8311081: KeytoolReaderP12Test.java fail on localized Windows platform
• 0eb3344: 8310807: java/nio/channels/DatagramChannel/Connect.java timed out
• 8fbdb41: 8315600: Open source few more headless Swing misc tests
• f1a41e2: 8315986: [macos14] javax/swing/JMenuItem/4654927/bug4654927.java: component must be showing on the screen to determine its location
• 0e640dc: 8316106: Open source few swing JInternalFrame and JMenuBar tests
• 0cdc070: 8319922: libCreationTimeHelper.so fails to link in JDK 21
• d7c67fc: 8261404: Class.getReflectionFactory() is not thread-safe
• ... and 8 more: https://git.openjdk.org/jdk17u-dev/compare/8e50363853decbb86607f2bcb1a4e8cb9fc284a4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @earthling-amzn Pushed as commit 5e8883e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.