8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id

[mmyxym]

Clean backport for fixing JFR crash. The root cause is creating threads in JNI function can overlap with the JFR safepoint op and accessing a NULL threadobj. The original commit fixed the potential NULL access.

Additional testing:

• Linux aarch64 server fastdebug, test/jdk/jdk/jfr passed

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8276125 needs maintainer approval

Issue

• JDK-8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2179/head:pull/2179
$ git checkout pull/2179

Update a local copy of the PR:
$ git checkout pull/2179
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2179/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2179

View PR using the GUI difftool:
$ git pr show -t 2179

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2179.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back lmao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @mmyxym This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mmyxym]

/approval request Clean backport for fixing JFR crash. The root cause is creating threads in JNI function can overlap with the JFR safepoint op and accessing a NULL threadobj. The original commit fixed the potential NULL access. The risk is very low that it's a clean backport and the null pointer check is rather simple.

[openjdk]

@mmyxym
8276125: The approval request has been created successfully.

[mlbridge]

Webrevs

• 00: Full (d076aaac)

[openjdk]

@mmyxym This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 9926d7c: 8324659: GHA: Generic jtreg errors are not reported
• 6d8febb: 8309870: Using -proc:full should be considered requesting explicit annotation processing
• 8fffc07: 8315761: Open source few swing JList and JMenuBar tests
• f248ea8: 8318608: Enable parallelism in vmTestbase/nsk/stress/threads tests
• 86df8c2: 8296631: NSS tests failing on OL9 linux-aarch64 hosts

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mmyxym]

/integrate

[openjdk]

@mmyxym
Your change (at version d076aaa) is now ready to be sponsored by a Committer.

[mmyxym]

Could committers please help sponsor, thanks!

[shipilev]

Yes, this makes sense, thanks.

/sponsor

[openjdk]

Going to push as commit 2500dbe.
Since your change was applied there have been 15 commits pushed to the master branch:

• 43049fd: 8209595: MonitorVmStartTerminate.java timed out
• 50222fc: 8311081: KeytoolReaderP12Test.java fail on localized Windows platform
• 0eb3344: 8310807: java/nio/channels/DatagramChannel/Connect.java timed out
• 8fbdb41: 8315600: Open source few more headless Swing misc tests
• f1a41e2: 8315986: [macos14] javax/swing/JMenuItem/4654927/bug4654927.java: component must be showing on the screen to determine its location
• 0e640dc: 8316106: Open source few swing JInternalFrame and JMenuBar tests
• 0cdc070: 8319922: libCreationTimeHelper.so fails to link in JDK 21
• d7c67fc: 8261404: Class.getReflectionFactory() is not thread-safe
• 3432698: 8324280: RISC-V: Incorrect implementation in VM_Version::parse_satp_mode
• 184fac8: 8316304: (fs) Add support for BasicFileAttributes.creationTime() for Linux
• ... and 5 more: https://git.openjdk.org/jdk17u-dev/compare/3be072926d74cc3af0f8f98c4ce2698a169ce80a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @mmyxym Pushed as commit 2500dbe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[mmyxym]

Yes, this makes sense, thanks.

/sponsor

Aleksey, thanks!