Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315611: Open source swing text/html and tree test #2183

Closed
wants to merge 1 commit into from

Conversation

amosshi
Copy link
Contributor

@amosshi amosshi commented Jan 28, 2024

Backport of JDK-8315611

Testing

  • Local: Passed
    • test/jdk/javax/swing/text/html/TableView/bug4813831.java - Test results: passed: 1
    • test/jdk/javax/swing/tree/DefaultTreeCellEditor/ - Test results: passed: 1
    • test/jdk/javax/swing/tree/DefaultTreeCellRenderer/bug4180224.java - Test results: passed: 1
    • test/jdk/javax/swing/tree/FixedHeightLayoutCache/ - Test results: passed: 1
  • Pipeline: All checks have passed
  • Testing Machine: SAP nightlies passed on 2024-01-29

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8315611 needs maintainer approval

Issue

  • JDK-8315611: Open source swing text/html and tree test (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2183/head:pull/2183
$ git checkout pull/2183

Update a local copy of the PR:
$ git checkout pull/2183
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2183/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2183

View PR using the GUI difftool:
$ git pr show -t 2183

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2183.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 28, 2024

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ae08143d3dd3aa559447623389a5b23c5d32398a 8315611: Open source swing text/html and tree test Jan 28, 2024
@openjdk
Copy link

openjdk bot commented Jan 28, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 28, 2024

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 28, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 28, 2024

Webrevs

@amosshi
Copy link
Contributor Author

amosshi commented Jan 29, 2024

/approval request “Backporting for parity with jdk 17.0.11-oracle. No risk, test fix. Clean backport. SAP nightlies passed on 2024-01-29”

@openjdk
Copy link

openjdk bot commented Jan 29, 2024

@amosshi
8315611: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jan 29, 2024
@openjdk
Copy link

openjdk bot commented Jan 30, 2024

@amosshi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315611: Open source swing text/html and tree test

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • 41ec53c: 8318607: Enable parallelism in vmTestbase/nsk/stress/jni tests
  • 5e8883e: 8321815: Shenandoah: gc state should be synchronized to java threads only once per safepoint
  • 0790496: 8317144: Exclude sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java on Linux ppc64le
  • 2500dbe: 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id
  • 43049fd: 8209595: MonitorVmStartTerminate.java timed out
  • 50222fc: 8311081: KeytoolReaderP12Test.java fail on localized Windows platform
  • 0eb3344: 8310807: java/nio/channels/DatagramChannel/Connect.java timed out
  • 8fbdb41: 8315600: Open source few more headless Swing misc tests
  • f1a41e2: 8315986: [macos14] javax/swing/JMenuItem/4654927/bug4654927.java: component must be showing on the screen to determine its location
  • 0e640dc: 8316106: Open source few swing JInternalFrame and JMenuBar tests
  • ... and 7 more: https://git.openjdk.org/jdk17u-dev/compare/f248ea887a8ef2143d073fdcecc7dc882f514686...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 30, 2024
@amosshi
Copy link
Contributor Author

amosshi commented Jan 30, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 30, 2024
@openjdk
Copy link

openjdk bot commented Jan 30, 2024

@amosshi
Your change (at version d94c286) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Jan 31, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 31, 2024

Going to push as commit 5421b29.
Since your change was applied there have been 17 commits pushed to the master branch:

  • 41ec53c: 8318607: Enable parallelism in vmTestbase/nsk/stress/jni tests
  • 5e8883e: 8321815: Shenandoah: gc state should be synchronized to java threads only once per safepoint
  • 0790496: 8317144: Exclude sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java on Linux ppc64le
  • 2500dbe: 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id
  • 43049fd: 8209595: MonitorVmStartTerminate.java timed out
  • 50222fc: 8311081: KeytoolReaderP12Test.java fail on localized Windows platform
  • 0eb3344: 8310807: java/nio/channels/DatagramChannel/Connect.java timed out
  • 8fbdb41: 8315600: Open source few more headless Swing misc tests
  • f1a41e2: 8315986: [macos14] javax/swing/JMenuItem/4654927/bug4654927.java: component must be showing on the screen to determine its location
  • 0e640dc: 8316106: Open source few swing JInternalFrame and JMenuBar tests
  • ... and 7 more: https://git.openjdk.org/jdk17u-dev/compare/f248ea887a8ef2143d073fdcecc7dc882f514686...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 31, 2024
@openjdk openjdk bot closed this Jan 31, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 31, 2024
@openjdk
Copy link

openjdk bot commented Jan 31, 2024

@GoeLin @amosshi Pushed as commit 5421b29.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@amosshi amosshi deleted the backport-8315611 branch February 1, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants