Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8310923: Refactor Currency tests to use JUnit #2187

Closed

Conversation

luchenlin
Copy link

@luchenlin luchenlin commented Jan 31, 2024

I backport this for parity with 17.0.11-oracle.
All Locale constructors change to new Locale("", country) due to JDK-8283698 has not been backported.
Local test pass.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8310923 needs maintainer approval

Issue

  • JDK-8310923: Refactor Currency tests to use JUnit (Sub-task - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2187/head:pull/2187
$ git checkout pull/2187

Update a local copy of the PR:
$ git checkout pull/2187
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2187/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2187

View PR using the GUI difftool:
$ git pr show -t 2187

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2187.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 31, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e848d9471f5de86e5ac157b710cd7371f12f0024 8310923: Refactor Currency tests to use JUnit Jan 31, 2024
@openjdk
Copy link

openjdk bot commented Jan 31, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jan 31, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 31, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 31, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Feb 1, 2024
@GoeLin
Copy link
Member

GoeLin commented Feb 1, 2024

Thanks for redoing this!

@openjdk
Copy link

openjdk bot commented Feb 1, 2024

@luchenlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310923: Refactor Currency tests to use JUnit

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 5421b29: 8315611: Open source swing text/html and tree test

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 1, 2024
@luchenlin
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 1, 2024

Going to push as commit 44ed380.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 8364974: 8280241: (aio) AsynchronousSocketChannel init fails in IPv6 only Windows env
  • 5421b29: 8315611: Open source swing text/html and tree test

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 1, 2024
@openjdk openjdk bot closed this Feb 1, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 1, 2024
@openjdk
Copy link

openjdk bot commented Feb 1, 2024

@luchenlin Pushed as commit 44ed380.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants