Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321480: ISO 4217 Amendment 176 Update #2190

Closed

Conversation

luchenlin
Copy link

@luchenlin luchenlin commented Feb 1, 2024

I backport this for parity with 17.0.11-oracle.
all clean except: src/java.base/share/data/currency/CurrencyData.properties file path has been changed, backport to the origin file.
Local test pass.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8321480 needs maintainer approval

Issue

  • JDK-8321480: ISO 4217 Amendment 176 Update (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2190/head:pull/2190
$ git checkout pull/2190

Update a local copy of the PR:
$ git checkout pull/2190
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2190/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2190

View PR using the GUI difftool:
$ git pr show -t 2190

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2190.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 1, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8b24851b9d3619c41c7a6cdb9193ed26a9b732dc 8321480: ISO 4217 Amendment 176 Update Feb 1, 2024
@openjdk
Copy link

openjdk bot commented Feb 1, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 1, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 1, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 5, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Feb 5, 2024
@openjdk
Copy link

openjdk bot commented Feb 5, 2024

@luchenlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321480: ISO 4217 Amendment 176 Update

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 4126c01: 8323637: Capture hotspot replay files in GHA
  • 58d2ceb: 8324937: GHA: Avoid multiple test suites per job

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 5, 2024
@luchenlin
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 6, 2024

Going to push as commit 223018a.
Since your change was applied there have been 3 commits pushed to the master branch:

  • fc49554: 8320168: handle setsocktopt return values
  • 4126c01: 8323637: Capture hotspot replay files in GHA
  • 58d2ceb: 8324937: GHA: Avoid multiple test suites per job

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 6, 2024
@openjdk openjdk bot closed this Feb 6, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 6, 2024
@openjdk
Copy link

openjdk bot commented Feb 6, 2024

@luchenlin Pushed as commit 223018a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants