Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321408: Add Certainly roots R1 and E1 #2217

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Feb 21, 2024

Unclean backport to roll in two more root certificates and better parity.

I had to move the certificates in their proper places in 17u and regenerate the cacert checksum. (I am actually surprised we have to do this, but that must be because keystore type changed with JDK-8275252)

Additional testing:

  • jdk/security/infra sun/security/lib/cacerts tests pass with new certificates

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8321408 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8321408: Add Certainly roots R1 and E1 (Enhancement - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2217/head:pull/2217
$ git checkout pull/2217

Update a local copy of the PR:
$ git checkout pull/2217
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2217/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2217

View PR using the GUI difftool:
$ git pr show -t 2217

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2217.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 21, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@shipilev
Copy link
Member Author

/approval request Unclean backport to roll in two more root certificates and better parity. Relevant tests pass.

@openjdk openjdk bot changed the title Backport f3073db42aa80b3ced47edea8d2e8add874fb70f 8321408: Add Certainly roots R1 and E1 Feb 21, 2024
@openjdk
Copy link

openjdk bot commented Feb 21, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 21, 2024
@openjdk
Copy link

openjdk bot commented Feb 21, 2024

@shipilev
8321408: The approval request has been created successfully.

@mlbridge
Copy link

mlbridge bot commented Feb 21, 2024

Webrevs

@openjdk openjdk bot added the approval label Feb 21, 2024
Copy link
Member

@GoeLin GoeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Yes, updating the hash is a nuisance.

@openjdk
Copy link

openjdk bot commented Feb 22, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@shipilev
Copy link
Member Author

/approval request Unclean backport to roll in two more root certificates and better parity. Relevant tests pass.

@openjdk
Copy link

openjdk bot commented Feb 22, 2024

@shipilev
8321408: The approval request was already up to date.

@RealCLanger
Copy link
Contributor

/approve yes

@openjdk
Copy link

openjdk bot commented Feb 22, 2024

@RealCLanger
8321408: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Feb 22, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321408: Add Certainly roots R1 and E1

Reviewed-by: goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 65 new commits pushed to the master branch:

  • 2c2b372: 8314830: runtime/ErrorHandling/ tests ignore external VM flags
  • 303e8de: 8325585: Remove no longer necessary calls to set/unset-in-asgct flag in JDK 17
  • 47b916d: 8314164: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fails intermittently in timeout
  • ef598eb: 8306408: Fix the format of several tables in building.md
  • 3285292: 8308336: Test java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java failed: java.net.BindException: Address already in use
  • b27d63f: 8318468: compiler/tiered/LevelTransitionTest.java fails with -XX:CompileThreshold=100 -XX:TieredStopAtLevel=1
  • f64f07f: 8315602: Open source swing security manager test
  • d6ad2f1: 8274122: java/io/File/createTempFile/SpecialTempFile.java fails in Windows 11
  • ed7c6f4: 8324347: Enable "maybe-uninitialized" warning for FreeType 2.13.1
  • 4395668: 8305906: HttpClient may use incorrect key when finding pooled HTTP/2 connection for IPv6 address
  • ... and 55 more: https://git.openjdk.org/jdk17u-dev/compare/a6135d783d49dc8047375f62bd969b0874a21891...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 22, 2024
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 22, 2024

Going to push as commit e8f7eae.
Since your change was applied there have been 66 commits pushed to the master branch:

  • 4701c03: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed
  • 2c2b372: 8314830: runtime/ErrorHandling/ tests ignore external VM flags
  • 303e8de: 8325585: Remove no longer necessary calls to set/unset-in-asgct flag in JDK 17
  • 47b916d: 8314164: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fails intermittently in timeout
  • ef598eb: 8306408: Fix the format of several tables in building.md
  • 3285292: 8308336: Test java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java failed: java.net.BindException: Address already in use
  • b27d63f: 8318468: compiler/tiered/LevelTransitionTest.java fails with -XX:CompileThreshold=100 -XX:TieredStopAtLevel=1
  • f64f07f: 8315602: Open source swing security manager test
  • d6ad2f1: 8274122: java/io/File/createTempFile/SpecialTempFile.java fails in Windows 11
  • ed7c6f4: 8324347: Enable "maybe-uninitialized" warning for FreeType 2.13.1
  • ... and 56 more: https://git.openjdk.org/jdk17u-dev/compare/a6135d783d49dc8047375f62bd969b0874a21891...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 22, 2024
@openjdk openjdk bot closed this Feb 22, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 22, 2024
@openjdk
Copy link

openjdk bot commented Feb 22, 2024

@shipilev Pushed as commit e8f7eae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants