Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8323515: Create test alias "all" for all test roots #2221

Closed
wants to merge 2 commits into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Feb 22, 2024

Improves JDK 17u testability by allowing to run all tests at once. There was a contextual conflict around langtools_sjavac test group, which was removed in the later release with JDK-8297041. Test groups sanity is going to be tested with GHA.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8324647 needs maintainer approval
  • JDK-8323515 needs maintainer approval

Issues

  • JDK-8323515: Create test alias "all" for all test roots (Enhancement - P4 - Approved)
  • JDK-8324647: Invalid test group of lib-test after JDK-8323515 (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2221/head:pull/2221
$ git checkout pull/2221

Update a local copy of the PR:
$ git checkout pull/2221
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2221/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2221

View PR using the GUI difftool:
$ git pr show -t 2221

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2221.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 22, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8b9bf758801400e4491326cd4c90fc117b9d97e1 8323515: Create test alias "all" for all test roots Feb 22, 2024
@openjdk
Copy link

openjdk bot commented Feb 22, 2024

This backport pull request has now been updated with issue from the original commit.

@shipilev
Copy link
Member Author

/issue add JDK-8324647

@openjdk openjdk bot removed the clean label Feb 22, 2024
@openjdk
Copy link

openjdk bot commented Feb 22, 2024

@shipilev
Adding additional issue to issue list: 8324647: Invalid test group of lib-test after JDK-8323515.

@shipilev shipilev marked this pull request as ready for review February 22, 2024 20:18
@shipilev
Copy link
Member Author

/approval request 8323515 Improves JDK 17u testability by allowing to run all tests at once. There was a contextual conflict, resolved manually. Test groups sanity is tested with GHA. Requires JDK-8324647 as the followup.

/approval request 8324647 Follow-up fix for JDK-8323515.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 22, 2024
@openjdk
Copy link

openjdk bot commented Feb 22, 2024

@shipilev
8323515: The approval request has been created successfully.
8324647: The approval request has been created successfully.

@openjdk
Copy link

openjdk bot commented Feb 22, 2024

@shipilev
8323515: The approval request has been updated successfully.
8324647: The approval request has been updated successfully.

@openjdk openjdk bot added the approval label Feb 22, 2024
@shipilev
Copy link
Member Author

/approval JDK-8323515 request Improves JDK 17u testability by allowing to run all tests at once. There was a contextual conflict, resolved manually. Test groups sanity is tested with GHA. Requires JDK-8324647 as the followup.

/approval JDK-8324647 request Follow-up fix for JDK-8323515.

@openjdk
Copy link

openjdk bot commented Feb 22, 2024

@shipilev
JDK-8323515: The approval request has been updated successfully.

@openjdk
Copy link

openjdk bot commented Feb 22, 2024

@shipilev
JDK-8324647: The approval request has been updated successfully.

@mlbridge
Copy link

mlbridge bot commented Feb 22, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 22, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Feb 23, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323515: Create test alias "all" for all test roots
8324647: Invalid test group of lib-test after JDK-8323515

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 71 new commits pushed to the master branch:

  • 95ca457: 8294158: HTML formatting for PassFailJFrame instructions
  • 5de649a: 8294535: Add screen capture functionality to PassFailJFrame
  • ab1e3cf: 8288846: misc tests fail "assert(ms < 1000) failed: Un-interruptable sleep, short time use only"
  • f4fd2cb: 8290041: ModuleDescriptor.hashCode is inconsistent
  • e8f7eae: 8321408: Add Certainly roots R1 and E1
  • 4701c03: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed
  • 2c2b372: 8314830: runtime/ErrorHandling/ tests ignore external VM flags
  • 303e8de: 8325585: Remove no longer necessary calls to set/unset-in-asgct flag in JDK 17
  • 47b916d: 8314164: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fails intermittently in timeout
  • ef598eb: 8306408: Fix the format of several tables in building.md
  • ... and 61 more: https://git.openjdk.org/jdk17u-dev/compare/a6135d783d49dc8047375f62bd969b0874a21891...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 23, 2024
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 26, 2024

Going to push as commit a59c2eb.
Since your change was applied there have been 71 commits pushed to the master branch:

  • 95ca457: 8294158: HTML formatting for PassFailJFrame instructions
  • 5de649a: 8294535: Add screen capture functionality to PassFailJFrame
  • ab1e3cf: 8288846: misc tests fail "assert(ms < 1000) failed: Un-interruptable sleep, short time use only"
  • f4fd2cb: 8290041: ModuleDescriptor.hashCode is inconsistent
  • e8f7eae: 8321408: Add Certainly roots R1 and E1
  • 4701c03: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed
  • 2c2b372: 8314830: runtime/ErrorHandling/ tests ignore external VM flags
  • 303e8de: 8325585: Remove no longer necessary calls to set/unset-in-asgct flag in JDK 17
  • 47b916d: 8314164: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fails intermittently in timeout
  • ef598eb: 8306408: Fix the format of several tables in building.md
  • ... and 61 more: https://git.openjdk.org/jdk17u-dev/compare/a6135d783d49dc8047375f62bd969b0874a21891...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 26, 2024
@openjdk openjdk bot closed this Feb 26, 2024
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Feb 26, 2024
@openjdk openjdk bot removed the rfr Pull request is ready for review label Feb 26, 2024
@openjdk
Copy link

openjdk bot commented Feb 26, 2024

@shipilev Pushed as commit a59c2eb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants