-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8323515: Create test alias "all" for all test roots #2221
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
/issue add JDK-8324647 |
@shipilev |
/approval request 8323515 Improves JDK 17u testability by allowing to run all tests at once. There was a contextual conflict, resolved manually. Test groups sanity is tested with GHA. Requires JDK-8324647 as the followup. /approval request 8324647 Follow-up fix for JDK-8323515. |
/approval JDK-8323515 request Improves JDK 17u testability by allowing to run all tests at once. There was a contextual conflict, resolved manually. Test groups sanity is tested with GHA. Requires JDK-8324647 as the followup. /approval JDK-8324647 request Follow-up fix for JDK-8323515. |
|
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 71 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit a59c2eb.
Your commit was automatically rebased without conflicts. |
Improves JDK 17u testability by allowing to run all tests at once. There was a contextual conflict around
langtools_sjavac
test group, which was removed in the later release with JDK-8297041. Test groups sanity is going to be tested with GHA.Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2221/head:pull/2221
$ git checkout pull/2221
Update a local copy of the PR:
$ git checkout pull/2221
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2221/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2221
View PR using the GUI difftool:
$ git pr show -t 2221
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2221.diff
Webrev
Link to Webrev Comment