8325254: CKA_TOKEN private and secret keys are not necessarily sensitive

[martinuy]

Hello,

I would like to propose a backport of the 8325254 fix to 17u as this release is affected by the bug. Note: all releases that have 8271566 are affected. Risk is minimal.

Thanks

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8325254 needs maintainer approval

Issue

• JDK-8325254: CKA_TOKEN private and secret keys are not necessarily sensitive (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2223/head:pull/2223
$ git checkout pull/2223

Update a local copy of the PR:
$ git checkout pull/2223
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2223/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2223

View PR using the GUI difftool:
$ git pr show -t 2223

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2223.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbalao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @martinuy This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (d210fc93)

[martinuy]

/approval request 17u is affected by this bug because it has 8271566 that introduced it. Risk is minimal.

[openjdk]

@martinuy
8325254: The approval request has been created successfully.

[openjdk]

@martinuy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325254: CKA_TOKEN private and secret keys are not necessarily sensitive

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 3c0b302: 8326794: Bump update version for OpenJDK: jdk-17.0.12
• 39c9e9d: 8326000: Remove obsolete comments for class sun.security.ssl.SunJSSE
• 075c56f: 8310380: Handle problems in core-related tests on macOS when codesign tool does not work
• b993b74: 8278312: Update SimpleSSLContext keystore to use SANs for localhost IP addresses
• 409d27b: 8321151: JDK-8294427 breaks Windows L&F on all older Windows versions
• 6788e5f: 8305962: update jcstress to 0.16
• a59c2eb: 8323515: Create test alias "all" for all test roots
• 95ca457: 8294158: HTML formatting for PassFailJFrame instructions
• 5de649a: 8294535: Add screen capture functionality to PassFailJFrame
• ab1e3cf: 8288846: misc tests fail "assert(ms < 1000) failed: Un-interruptable sleep, short time use only"
• ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/e8f7eaeefe503a34089fd49051f9114d98a63cb1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[martinuy]

/integrate

[openjdk]

Going to push as commit 7bd9062.
Since your change was applied there have been 11 commits pushed to the master branch:

• 3c0b302: 8326794: Bump update version for OpenJDK: jdk-17.0.12
• 39c9e9d: 8326000: Remove obsolete comments for class sun.security.ssl.SunJSSE
• 075c56f: 8310380: Handle problems in core-related tests on macOS when codesign tool does not work
• b993b74: 8278312: Update SimpleSSLContext keystore to use SANs for localhost IP addresses
• 409d27b: 8321151: JDK-8294427 breaks Windows L&F on all older Windows versions
• 6788e5f: 8305962: update jcstress to 0.16
• a59c2eb: 8323515: Create test alias "all" for all test roots
• 95ca457: 8294158: HTML formatting for PassFailJFrame instructions
• 5de649a: 8294535: Add screen capture functionality to PassFailJFrame
• ab1e3cf: 8288846: misc tests fail "assert(ms < 1000) failed: Un-interruptable sleep, short time use only"
• ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/e8f7eaeefe503a34089fd49051f9114d98a63cb1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@martinuy Pushed as commit 7bd9062.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[GoeLin]

@martinuy
Hi, this breaks the build. See also GHA tests. I'll back it out.

[GoeLin]

@martinuy, See https://bugs.openjdk.org/browse/JDK-8326942