Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294158: HTML formatting for PassFailJFrame instructions #2224

Closed

Conversation

luchenlin
Copy link

@luchenlin luchenlin commented Feb 23, 2024

I backport this for parity with 17.0.11-oracle.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8294158 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8294158: HTML formatting for PassFailJFrame instructions (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2224/head:pull/2224
$ git checkout pull/2224

Update a local copy of the PR:
$ git checkout pull/2224
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2224/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2224

View PR using the GUI difftool:
$ git pr show -t 2224

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2224.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 23, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 14090ef6039ff2f3064f397a75219b2bc715cc27 8294158: HTML formatting for PassFailJFrame instructions Feb 23, 2024
@openjdk
Copy link

openjdk bot commented Feb 23, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 23, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 23, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 23, 2024

Webrevs

@openjdk openjdk bot added the approval label Feb 26, 2024
@openjdk
Copy link

openjdk bot commented Feb 26, 2024

@luchenlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294158: HTML formatting for PassFailJFrame instructions

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 26, 2024
@luchenlin
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 26, 2024

Going to push as commit 95ca457.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 26, 2024
@openjdk openjdk bot closed this Feb 26, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 26, 2024
@openjdk
Copy link

openjdk bot commented Feb 26, 2024

@luchenlin Pushed as commit 95ca457.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant