Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8326000: Remove obsolete comments for class sun.security.ssl.SunJSSE #2225

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Feb 23, 2024

Hi all,

This pull request contains a backport of JDK-8326000, commit c2d9fa26 from the openjdk/jdk repository.

The commit being backported was authored by Christoph Langer on 18 Feb 2024 and was reviewed by Matthias Baesken and Anthony Scarpino.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8326000 needs maintainer approval

Issue

  • JDK-8326000: Remove obsolete comments for class sun.security.ssl.SunJSSE (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2225/head:pull/2225
$ git checkout pull/2225

Update a local copy of the PR:
$ git checkout pull/2225
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2225/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2225

View PR using the GUI difftool:
$ git pr show -t 2225

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2225.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 23, 2024

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c2d9fa26ce903be7c86a47db5ff289cdb9de3a62 8326000: Remove obsolete comments for class sun.security.ssl.SunJSSE Feb 23, 2024
@openjdk
Copy link

openjdk bot commented Feb 23, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 23, 2024

⚠️ @RealCLanger This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 23, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 23, 2024

Webrevs

@RealCLanger
Copy link
Contributor Author

/approval request Comment removal that applies cleanly. The according code was already removed in JDK13 so this applies for JDK 17 as well. No risk.

@openjdk
Copy link

openjdk bot commented Feb 23, 2024

@RealCLanger
8326000: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Feb 23, 2024
@openjdk
Copy link

openjdk bot commented Feb 26, 2024

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326000: Remove obsolete comments for class sun.security.ssl.SunJSSE

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 95ca457: 8294158: HTML formatting for PassFailJFrame instructions

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 26, 2024
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 27, 2024

Going to push as commit 39c9e9d.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 075c56f: 8310380: Handle problems in core-related tests on macOS when codesign tool does not work
  • b993b74: 8278312: Update SimpleSSLContext keystore to use SANs for localhost IP addresses
  • 409d27b: 8321151: JDK-8294427 breaks Windows L&F on all older Windows versions
  • 6788e5f: 8305962: update jcstress to 0.16
  • a59c2eb: 8323515: Create test alias "all" for all test roots
  • 95ca457: 8294158: HTML formatting for PassFailJFrame instructions

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 27, 2024
@openjdk openjdk bot closed this Feb 27, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 27, 2024
@openjdk
Copy link

openjdk bot commented Feb 27, 2024

@RealCLanger Pushed as commit 39c9e9d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant