-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8326000: Remove obsolete comments for class sun.security.ssl.SunJSSE #2225
8326000: Remove obsolete comments for class sun.security.ssl.SunJSSE #2225
Conversation
👋 Welcome back clanger! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Comment removal that applies cleanly. The according code was already removed in JDK13 so this applies for JDK 17 as well. No risk. |
@RealCLanger |
@RealCLanger This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 39c9e9d.
Your commit was automatically rebased without conflicts. |
@RealCLanger Pushed as commit 39c9e9d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of JDK-8326000, commit c2d9fa26 from the openjdk/jdk repository.
The commit being backported was authored by Christoph Langer on 18 Feb 2024 and was reviewed by Matthias Baesken and Anthony Scarpino.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2225/head:pull/2225
$ git checkout pull/2225
Update a local copy of the PR:
$ git checkout pull/2225
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2225/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2225
View PR using the GUI difftool:
$ git pr show -t 2225
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2225.diff
Webrev
Link to Webrev Comment