-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8280030: [REDO] Parallel: More precise boundary in ObjectStartArray::object_starts_in_range #2226
Conversation
…object_starts_in_range Reviewed-by: sjohanss, tschatzl
👋 Welcome back rrich! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@reinrich This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 37 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thanks for review and approval! |
Going to push as commit dbf4a99.
Your commit was automatically rebased without conflicts. |
This backport is a transitive dependency for the backport of https://bugs.openjdk.org/browse/JDK-8310031
8310031 requires 8282094: [REDO] Parallel: Refactor PSCardTable::scavenge_contents_parallel
and 8282094 requires this backport.
8310031 could be backported w/o this backport if 8282094 could be squashed into it because with 8310031
ObjectStartArray::object_starts_in_range()
is not reached anymore fromPSCardTable::scavenge_contents_parallel()
.This backport applies cleanly but needs a trivial renaming (see 2nd commit).
Risk is low: it's a small change. The changed method has just 2 callers of which one is for diagnostics.
Manual testing on x86_64:
jdk:tier1 TEST_VM_OPTS="-XX:+UseParallelGC"
langtools:tier1 TEST_VM_OPTS="-XX:+UseParallelGC"
Local CI Testing:
The fix passed our CI testing (e.g. 2024-02-22): JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC).
Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2226/head:pull/2226
$ git checkout pull/2226
Update a local copy of the PR:
$ git checkout pull/2226
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2226/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2226
View PR using the GUI difftool:
$ git pr show -t 2226
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2226.diff
Webrev
Link to Webrev Comment