Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280030: [REDO] Parallel: More precise boundary in ObjectStartArray::object_starts_in_range #2226

Closed
wants to merge 2 commits into from

Conversation

reinrich
Copy link
Member

@reinrich reinrich commented Feb 23, 2024

This backport is a transitive dependency for the backport of https://bugs.openjdk.org/browse/JDK-8310031

8310031 requires 8282094: [REDO] Parallel: Refactor PSCardTable::scavenge_contents_parallel
and 8282094 requires this backport.

8310031 could be backported w/o this backport if 8282094 could be squashed into it because with 8310031 ObjectStartArray::object_starts_in_range() is not reached anymore from PSCardTable::scavenge_contents_parallel().

This backport applies cleanly but needs a trivial renaming (see 2nd commit).

Risk is low: it's a small change. The changed method has just 2 callers of which one is for diagnostics.

Manual testing on x86_64:
jdk:tier1 TEST_VM_OPTS="-XX:+UseParallelGC"
langtools:tier1 TEST_VM_OPTS="-XX:+UseParallelGC"

Local CI Testing:
The fix passed our CI testing (e.g. 2024-02-22): JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC).
Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8280030 needs maintainer approval

Issue

  • JDK-8280030: [REDO] Parallel: More precise boundary in ObjectStartArray::object_starts_in_range (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2226/head:pull/2226
$ git checkout pull/2226

Update a local copy of the PR:
$ git checkout pull/2226
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2226/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2226

View PR using the GUI difftool:
$ git pr show -t 2226

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2226.diff

Webrev

Link to Webrev Comment

albertnetymk and others added 2 commits February 21, 2024 13:53
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 23, 2024

👋 Welcome back rrich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 23, 2024

⚠️ @reinrich the given backport hash 7319e4ed482845b61cbce2f7785c77b91ab94b81 is an ancestor of your proposed change. Please update the title with the hash for the change you are backporting.

@reinrich reinrich changed the title Backport 7319e4ed482845b61cbce2f7785c77b91ab94b81 Backport 496baada1021eecae03e737afe838ad6d383cba9 Feb 23, 2024
@openjdk openjdk bot changed the title Backport 496baada1021eecae03e737afe838ad6d383cba9 8280030: [REDO] Parallel: More precise boundary in ObjectStartArray::object_starts_in_range Feb 23, 2024
@openjdk
Copy link

openjdk bot commented Feb 23, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 23, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 23, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Feb 28, 2024

⚠️ @reinrich This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

Copy link
Contributor

@zhengyu123 zhengyu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk bot added the approval label Mar 6, 2024
@openjdk
Copy link

openjdk bot commented Mar 6, 2024

@reinrich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280030: [REDO] Parallel: More precise boundary in ObjectStartArray::object_starts_in_range

Reviewed-by: phh, zgu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

  • 47ec134: Merge
  • f45e587: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray
  • 72881de: 8305900: Use loopback IP addresses in security policy files of httpclient tests
  • 158f91a: 8272651: G1 heap region info print order changed by JDK-8269914
  • f3e90af: 8324824: AArch64: Detect Ampere-1B core and update default options for Ampere CPUs
  • bfe8974: 8323519: Add applications/ctw/modules to Hotspot tiered testing
  • 3add2e3: 8272903: Missing license header in ArenaAllocator.java
  • ab602af: 8323210: Update the usage of cmsFLAGS_COPY_ALPHA
  • 0052ab7: 8269914: Factor out heap printing for G1 young and full gc
  • 85a49ed: 8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name
  • ... and 27 more: https://git.openjdk.org/jdk17u-dev/compare/3285292597efd34176465df0b0394cc4a99605eb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 6, 2024
@reinrich
Copy link
Member Author

reinrich commented Mar 6, 2024

Thanks for review and approval!
/integrate

@openjdk
Copy link

openjdk bot commented Mar 6, 2024

Going to push as commit dbf4a99.
Since your change was applied there have been 37 commits pushed to the master branch:

  • 47ec134: Merge
  • f45e587: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray
  • 72881de: 8305900: Use loopback IP addresses in security policy files of httpclient tests
  • 158f91a: 8272651: G1 heap region info print order changed by JDK-8269914
  • f3e90af: 8324824: AArch64: Detect Ampere-1B core and update default options for Ampere CPUs
  • bfe8974: 8323519: Add applications/ctw/modules to Hotspot tiered testing
  • 3add2e3: 8272903: Missing license header in ArenaAllocator.java
  • ab602af: 8323210: Update the usage of cmsFLAGS_COPY_ALPHA
  • 0052ab7: 8269914: Factor out heap printing for G1 young and full gc
  • 85a49ed: 8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name
  • ... and 27 more: https://git.openjdk.org/jdk17u-dev/compare/3285292597efd34176465df0b0394cc4a99605eb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 6, 2024
@openjdk openjdk bot closed this Mar 6, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 6, 2024
@openjdk
Copy link

openjdk bot commented Mar 6, 2024

@reinrich Pushed as commit dbf4a99.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants