Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278893: Parallel: Remove GCWorkerDelayMillis #2227

Closed
wants to merge 4 commits into from

Conversation

reinrich
Copy link
Member

@reinrich reinrich commented Feb 23, 2024

This backport is a dependency for the backport of https://bugs.openjdk.org/browse/JDK-8310031
Applies cleanly.
No risk: only unused debug code is removed.

Local CI Testing:
The fix passed our CI testing (e.g. 2024-02-23): JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC).
Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8278893 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8278893: Parallel: Remove GCWorkerDelayMillis (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2227/head:pull/2227
$ git checkout pull/2227

Update a local copy of the PR:
$ git checkout pull/2227
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2227/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2227

View PR using the GUI difftool:
$ git pr show -t 2227

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2227.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 23, 2024

👋 Welcome back rrich! A progress list of the required criteria for merging this PR into pr/2226 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ff5d41762d5ba31e88c6cb9207a8ae57f34a69b0 8278893: Parallel: Remove GCWorkerDelayMillis Feb 23, 2024
@openjdk
Copy link

openjdk bot commented Feb 23, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Feb 23, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 23, 2024

Webrevs

@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout 8278893_backport_17
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot removed the clean label Mar 6, 2024
@openjdk openjdk bot added the clean label Mar 6, 2024
@openjdk
Copy link

openjdk bot commented Mar 6, 2024

@reinrich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278893: Parallel: Remove GCWorkerDelayMillis

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 6, 2024
@reinrich
Copy link
Member Author

reinrich commented Mar 6, 2024

riscv64 build error is unrelated. See https://bugs.openjdk.org/browse/JDK-8326960

@reinrich
Copy link
Member Author

reinrich commented Mar 6, 2024

Windows debug build error. Looks like the javac server was unavailable but this cannot be caused by this pr.

Connection attempt failed: Connection refused: no further information
Giving up
IOException caught during compilation: Could not connect to server after 10 attempts with timeout 4000
make[3]: *** [CompileDemos.gmk:161: /d/a/jdk17u-dev/jdk17u-dev/build/windows-x64/support/demos/classes/jfc/CodePointIM/_the.BUILD_DEMO_CodePointIM_batch] Error 1

@reinrich
Copy link
Member Author

reinrich commented Mar 6, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Mar 6, 2024

Going to push as commit 5421bb6.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 6, 2024
@openjdk openjdk bot closed this Mar 6, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 6, 2024
@openjdk
Copy link

openjdk bot commented Mar 6, 2024

@reinrich Pushed as commit 5421bb6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants