Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8305962: update jcstress to 0.16 #2234

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Feb 26, 2024

Clean backport to make JDK-8323717 backport clean. I had to resolve copyright years in TestGenerator.java.


Progress

  • JDK-8305962 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8305962: update jcstress to 0.16 (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2234/head:pull/2234
$ git checkout pull/2234

Update a local copy of the PR:
$ git checkout pull/2234
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2234/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2234

View PR using the GUI difftool:
$ git pr show -t 2234

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2234.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 26, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 292ee630ae32c3b50363b10ffa6090e57ffef1e8 8305962: update jcstress to 0.16 Feb 26, 2024
@openjdk
Copy link

openjdk bot commented Feb 26, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 26, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 26, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 26, 2024

Webrevs

@shipilev
Copy link
Member Author

/approval request Clean backport to make JDK-8323717 backport cleaner. I had to resolve copyright years in TestGenerator.java. There is no way to test this in OpenJDK, because these tests cannot be run without JIB. JDK-8323717 would provide a work around for that.

@openjdk
Copy link

openjdk bot commented Feb 26, 2024

@shipilev
8305962: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Feb 26, 2024
@openjdk
Copy link

openjdk bot commented Feb 26, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305962: update jcstress to 0.16

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • a59c2eb: 8323515: Create test alias "all" for all test roots

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 26, 2024
@shipilev
Copy link
Member Author

GHA failure looks like an infrastructure issue.

/integrate

@openjdk
Copy link

openjdk bot commented Feb 26, 2024

Going to push as commit 6788e5f.
Since your change was applied there has been 1 commit pushed to the master branch:

  • a59c2eb: 8323515: Create test alias "all" for all test roots

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 26, 2024
@openjdk openjdk bot closed this Feb 26, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 26, 2024
@openjdk
Copy link

openjdk bot commented Feb 26, 2024

@shipilev Pushed as commit 6788e5f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant