8323717: Introduce test keyword for tests that need external dependencies

[shipilev]

Semi-clean backport to allow running all tests cleanly. There was a contextual conflict in TEST.ROOT due to the absence of JDK-8317228 in 17u, which I think can be backported and resolved later.

Additional testing:

• applications/jcstress applications/scimark are now properly skipped with JTREG_KEYWORDS=\!external-dep

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8323717 needs maintainer approval

Issue

• JDK-8323717: Introduce test keyword for tests that need external dependencies (Enhancement - P4 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2236/head:pull/2236
$ git checkout pull/2236

Update a local copy of the PR:
$ git checkout pull/2236
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2236/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2236

View PR using the GUI difftool:
$ git pr show -t 2236

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2236.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (e4e14a53)
• 00: Full (1fcf983c)

[openjdk]

@shipilev Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk]

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[shipilev]

/approval request Clean backport to make sure we can exclude JIB-managed tests from all test runs. Makes all test group much more usable for ad-hoc runs. Applies with contextual differences, see 17u PR. Previously failing tests are now passing with !external-dep keyword supplied.

[openjdk]

@shipilev
8323717: The approval request has been created successfully.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323717: Introduce test keyword for tests that need external dependencies

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• 87e7c6e: 8326942: [17u] Backout "8325254: CKA_TOKEN private and secret keys are not necessarily sensitive"
• 8c3dcf3: 8324050: Issue store-store barrier after re-materializing objects during deoptimization
• 4b0a015: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16
• f9a33da: 8294156: Allow PassFailJFrame.Builder to create test UI
• c4a92c5: 8316053: Open some swing tests 3
• 31d16a1: 8315726: Open source several AWT applet tests
• 7bd9062: 8325254: CKA_TOKEN private and secret keys are not necessarily sensitive
• 3c0b302: 8326794: Bump update version for OpenJDK: jdk-17.0.12
• 39c9e9d: 8326000: Remove obsolete comments for class sun.security.ssl.SunJSSE
• 075c56f: 8310380: Handle problems in core-related tests on macOS when codesign tool does not work
• ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/6788e5f38392647f7f77794c1ab3f4a2671212e5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

/integrate

[openjdk]

Going to push as commit 204ec8a.
Since your change was applied there have been 12 commits pushed to the master branch:

• 87e7c6e: 8326942: [17u] Backout "8325254: CKA_TOKEN private and secret keys are not necessarily sensitive"
• 8c3dcf3: 8324050: Issue store-store barrier after re-materializing objects during deoptimization
• 4b0a015: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16
• f9a33da: 8294156: Allow PassFailJFrame.Builder to create test UI
• c4a92c5: 8316053: Open some swing tests 3
• 31d16a1: 8315726: Open source several AWT applet tests
• 7bd9062: 8325254: CKA_TOKEN private and secret keys are not necessarily sensitive
• 3c0b302: 8326794: Bump update version for OpenJDK: jdk-17.0.12
• 39c9e9d: 8326000: Remove obsolete comments for class sun.security.ssl.SunJSSE
• 075c56f: 8310380: Handle problems in core-related tests on macOS when codesign tool does not work
• ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/6788e5f38392647f7f77794c1ab3f4a2671212e5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 204ec8a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.