-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8325213: Flags introduced by configure script are not passed to ADLC build #2248
8325213: Flags introduced by configure script are not passed to ADLC build #2248
Conversation
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request I'd like to backport this trivial ADLC build fix. It may prevent build problems with future backports. Applies cleanly. Tested in SAP's internal builds. |
@TheRealMDoerr |
@TheRealMDoerr This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 5687c5a.
Your commit was automatically rebased without conflicts. |
@TheRealMDoerr Pushed as commit 5687c5a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean backport of the trivial ADLC build fix JDK-8325213.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2248/head:pull/2248
$ git checkout pull/2248
Update a local copy of the PR:
$ git checkout pull/2248
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2248/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2248
View PR using the GUI difftool:
$ git pr show -t 2248
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2248.diff
Webrev
Link to Webrev Comment