Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8326942: [17u] Backout "8325254: CKA_TOKEN private and secret keys are not necessarily sensitive" #2249

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Feb 28, 2024

…e not necessarily sensitive"

Backout this change that breaks the 17u build.

https://bugs.openjdk.org/browse/JDK-8325254


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8326942 needs maintainer approval

Issue

  • JDK-8326942: [17u] Backout "8325254: CKA_TOKEN private and secret keys are not necessarily sensitive" (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2249/head:pull/2249
$ git checkout pull/2249

Update a local copy of the PR:
$ git checkout pull/2249
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2249/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2249

View PR using the GUI difftool:
$ git pr show -t 2249

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2249.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 28, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8326942: [17u] Backout "8325254: CKA_TOKEN private and secret keys ar… 8326942: [17u] Backout "8325254: CKA_TOKEN private and secret keys are not necessarily sensitive" Feb 28, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 28, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 28, 2024

Webrevs

@openjdk openjdk bot added approval and removed approval labels Feb 28, 2024
Copy link

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Feb 28, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8326942: [17u] Backout "8325254: CKA_TOKEN private and secret keys are not necessarily sensitive"

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 28, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Feb 28, 2024

GHA failure: Risc-V build setup failure, unrelated

@GoeLin
Copy link
Member Author

GoeLin commented Feb 28, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Feb 28, 2024

Going to push as commit 87e7c6e.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 28, 2024
@openjdk openjdk bot closed this Feb 28, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 28, 2024
@openjdk
Copy link

openjdk bot commented Feb 28, 2024

@GoeLin Pushed as commit 87e7c6e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants