Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315834: Open source several Swing JSpinner related tests #2252

Closed
wants to merge 1 commit into from

Conversation

amosshi
Copy link
Contributor

@amosshi amosshi commented Feb 28, 2024

Backport of JDK-8315834

Testing

  • Local: Test passed
    • bug4522737.java - Test results: passed: 1
    • bug4656590.java - Test results: passed: 1
    • bug4680204.java - Test results: passed: 1
    • bug4862257.java - Test results: passed: 1
    • bug5104421.java - Test results: passed: 1
  • Pipeline: All checks have passed
  • Testing Machine: SAP nightlies passed on 2024-03-01,02,03

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8315834 needs maintainer approval

Issue

  • JDK-8315834: Open source several Swing JSpinner related tests (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2252/head:pull/2252
$ git checkout pull/2252

Update a local copy of the PR:
$ git checkout pull/2252
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2252/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2252

View PR using the GUI difftool:
$ git pr show -t 2252

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2252.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 28, 2024

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4a63eb05221c1829b157a025a4d35cdd77a9fe04 8315834: Open source several Swing JSpinner related tests Feb 28, 2024
@openjdk
Copy link

openjdk bot commented Feb 28, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 28, 2024

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 28, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 28, 2024

Webrevs

@amosshi
Copy link
Contributor Author

amosshi commented Mar 7, 2024

/approval request “Backporting for parity with jdk 17.0.12-oracle. Clean backport. Test case only, no risk. SAP nightlies passed on 2024-03-01,02,03”

@openjdk
Copy link

openjdk bot commented Mar 7, 2024

@amosshi
8315834: The approval request has been created successfully.

@openjdk openjdk bot added approval and removed approval labels Mar 7, 2024
@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@amosshi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315834: Open source several Swing JSpinner related tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 61 new commits pushed to the master branch:

  • fce02ad: 8326101: [PPC64] Need to bailout cleanly if creation of stubs fails when code cache is out of space
  • b0e3386: 8325326: [PPC64] Don't relocate in case of allocation failure
  • 373714b: 8322239: [macos] a11y : java.lang.NullPointerException is thrown when focus is moved on the JTabbedPane
  • 7d716fc: 8290901: Reduce use of -source in langtools tests
  • 807faa7: 8321489: Update LCMS to 2.16
  • dc60887: 8289401: Add dump output to TestRawRSACipher.java
  • 0499df3: 8285452: Add a new test library API to replace a file content using FileUtils.java
  • 4b9ab0d: 8286740: JFR: Active Setting event emitted incorrectly
  • c9b0307: 8268974: GetJREPath() JLI function fails to locate libjava.so if not standard Java launcher is used
  • 0b20589: 8324238: [macOS] java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails with the shape has not been applied msg
  • ... and 51 more: https://git.openjdk.org/jdk17u-dev/compare/39c9e9d2bf82cd85dc7d47031b71e97574533fe7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@amosshi
Copy link
Contributor Author

amosshi commented Mar 14, 2024

/approval request “Backporting for parity with jdk 17.0.12-oracle. Clean backport. Test case only - no risk. SAP nightlies passed on 2024-03-01,02,03”

@openjdk
Copy link

openjdk bot commented Mar 14, 2024

@amosshi
8315834: The approval request has been updated successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 14, 2024
@amosshi
Copy link
Contributor Author

amosshi commented Apr 9, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Apr 9, 2024

Going to push as commit c758755.
Since your change was applied there have been 136 commits pushed to the master branch:

  • fc01ffe: 8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters
  • c430b11: 8305645: System Tray icons get corrupted when Windows primary monitor changes
  • cb1a03c: 8325432: enhance assert message "relocation addr must be in this section"
  • 7217328: 8315652: RISC-V: Features string uses wrong separator for jtreg
  • 62e6dfa: 8313702: Update IANA Language Subtag Registry to Version 2023-08-02
  • 989e0bf: 8310818: Refactor more Locale tests to use JUnit
  • 533fac6: 8328638: Fallback option for POST-only OCSP requests
  • 31ba7e0: 8316462: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java ignores VM flags
  • b96339f: 8308021: Update IANA Language Subtag Registry to Version 2023-05-11
  • 261e45a: 8306031: Update IANA Language Subtag Registry to Version 2023-04-13
  • ... and 126 more: https://git.openjdk.org/jdk17u-dev/compare/39c9e9d2bf82cd85dc7d47031b71e97574533fe7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 9, 2024
@openjdk openjdk bot closed this Apr 9, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 9, 2024
@openjdk
Copy link

openjdk bot commented Apr 9, 2024

@amosshi Pushed as commit c758755.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@amosshi amosshi deleted the backport-8315834 branch April 9, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant