8268974: GetJREPath() JLI function fails to locate libjava.so if not standard Java launcher is used

[snazarkin]

I'd like to backport this changes as it fixes some custom launchers issue. Fix applies cleanly.

The functionality was tested with the new test and manually

    cd ~/tools/bin
    cp -r ~/jdk .
    cp jdk/bin/java jdk/lib
    jdk/lib/java -version

Without the patch JVM can't start

Error: could not find libjava.so
Error: Could not find Java SE Runtime Environment.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8268974 needs maintainer approval

Issue

• JDK-8268974: GetJREPath() JLI function fails to locate libjava.so if not standard Java launcher is used (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2257/head:pull/2257
$ git checkout pull/2257

Update a local copy of the PR:
$ git checkout pull/2257
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2257/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2257

View PR using the GUI difftool:
$ git pr show -t 2257

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2257.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back snazarki! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @snazarkin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (a8d4c09e)

[GoeLin]

@snazarkin, why are the GHA tests failing? Next time, I might just remove the fix-request label instead of asking. Testing is a prereq for labeling.

[snazarkin]

@snazarkin, why are the GHA tests failing? Next time, I might just remove the fix-request label instead of asking. Testing is a prereq for labeling.

It is riscv pipeline can't create sysroot. Looks like all PR for the last few days are failing

[snazarkin]

GHA failure: Risc-V build issue, unrelated.

[openjdk]

@snazarkin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268974: GetJREPath() JLI function fails to locate libjava.so if not standard Java launcher is used

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

• 49c260d: 8315898: Open source swing JMenu tests
• b632518: 8299858: [Metrics] Swap memory limit reported incorrectly when too large
• 3433fdb: 8314283: Support for NSS tests on aarch64 platforms
• 0606e5a: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries
• a22ac46: 8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14
• a14f845: 8320342: Use PassFailJFrame for TruncatedPopupMenuTest.java
• f8cfa35: 8319372: C2 compilation fails with "Bad immediate dominator info"
• 2d8a3a8: 8301381: Verify DTLS 1.0 cannot be negotiated
• dd94e20: 8256660: Disable DTLS 1.0
• f38add6: 8327036: [macosx-aarch64] SIGBUS in MarkActivationClosure::do_code_blob reached from Unsafe_CopySwapMemory0
• ... and 27 more: https://git.openjdk.org/jdk17u-dev/compare/5687c5a741522fd47fa00768a5054df6b7d5b6ed...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[snazarkin]

/integrate

[openjdk]

Going to push as commit c9b0307.
Since your change was applied there have been 42 commits pushed to the master branch:

• 0b20589: 8324238: [macOS] java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails with the shape has not been applied msg
• 27cf2f4: 8320943: Files/probeContentType/Basic.java fails on latest Windows 11 - content type mismatch
• 6488725: 8324598: use mem_unit when working with sysinfo memory and swap related information
• 02ef1c7: 8319128: sun/security/pkcs11 tests fail on OL 7.9 aarch64
• 09ebd1c: 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX
• 49c260d: 8315898: Open source swing JMenu tests
• b632518: 8299858: [Metrics] Swap memory limit reported incorrectly when too large
• 3433fdb: 8314283: Support for NSS tests on aarch64 platforms
• 0606e5a: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries
• a22ac46: 8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14
• ... and 32 more: https://git.openjdk.org/jdk17u-dev/compare/5687c5a741522fd47fa00768a5054df6b7d5b6ed...master

Your commit was automatically rebased without conflicts.

[openjdk]

@snazarkin Pushed as commit c9b0307.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.