Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8323519: Add applications/ctw/modules to Hotspot tiered testing #2258

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Feb 29, 2024

Clean backport to improve testing.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8323519 needs maintainer approval

Issue

  • JDK-8323519: Add applications/ctw/modules to Hotspot tiered testing (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2258/head:pull/2258
$ git checkout pull/2258

Update a local copy of the PR:
$ git checkout pull/2258
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2258/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2258

View PR using the GUI difftool:
$ git pr show -t 2258

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2258.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 29, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ba3c3bbd879eaf7532663663d73e21fafc65b574 8323519: Add applications/ctw/modules to Hotspot tiered testing Feb 29, 2024
@openjdk
Copy link

openjdk bot commented Feb 29, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 29, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 29, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 29, 2024

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Mar 1, 2024

/approval request Clean backport to improve testing. Applies cleanly. application/ctw tests pass in current jdk17u-dev, so the addition is safe for testing cleanliness. Risk is low, test configuration only change.

@shipilev
Copy link
Member Author

shipilev commented Mar 1, 2024

GHA failure is environmental.

@openjdk
Copy link

openjdk bot commented Mar 1, 2024

@shipilev
8323519: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Mar 1, 2024
@openjdk
Copy link

openjdk bot commented Mar 4, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323519: Add applications/ctw/modules to Hotspot tiered testing

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 3add2e3: 8272903: Missing license header in ArenaAllocator.java
  • ab602af: 8323210: Update the usage of cmsFLAGS_COPY_ALPHA
  • 0052ab7: 8269914: Factor out heap printing for G1 young and full gc
  • 85a49ed: 8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 4, 2024
@shipilev
Copy link
Member Author

shipilev commented Mar 4, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Mar 4, 2024

Going to push as commit bfe8974.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 3add2e3: 8272903: Missing license header in ArenaAllocator.java
  • ab602af: 8323210: Update the usage of cmsFLAGS_COPY_ALPHA
  • 0052ab7: 8269914: Factor out heap printing for G1 young and full gc
  • 85a49ed: 8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 4, 2024
@openjdk openjdk bot closed this Mar 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 4, 2024
@openjdk
Copy link

openjdk bot commented Mar 4, 2024

@shipilev Pushed as commit bfe8974.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant