Skip to content

8272903: Missing license header in ArenaAllocator.java#2262

Closed
offamitkumar wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-offamitkumar-96614da0
Closed

8272903: Missing license header in ArenaAllocator.java#2262
offamitkumar wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-offamitkumar-96614da0

Conversation

@offamitkumar
Copy link
Member

@offamitkumar offamitkumar commented Mar 1, 2024

Hi all,

This pull request contains a backport of commit 96614da0 from the openjdk/jdk repository.

The commit being backported was authored by Maurizio Cimadamore on 9 Sep 2021 and was reviewed by Brian Burkhalter and Lance Andersen.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8272903 needs maintainer approval

Issue

  • JDK-8272903: Missing license header in ArenaAllocator.java (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2262/head:pull/2262
$ git checkout pull/2262

Update a local copy of the PR:
$ git checkout pull/2262
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2262/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2262

View PR using the GUI difftool:
$ git pr show -t 2262

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2262.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 1, 2024

👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 96614da0254e7fd4ac9dd3c3059bf23c1aaf37ff 8272903: Missing license header in ArenaAllocator.java Mar 1, 2024
@openjdk
Copy link

openjdk bot commented Mar 1, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Mar 1, 2024
@openjdk
Copy link

openjdk bot commented Mar 1, 2024

⚠️ @offamitkumar This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 1, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 1, 2024

Webrevs

@offamitkumar
Copy link
Member Author

/approval request Header was missing in JDK-17 and JDK-18 original PR added for JDK-18 but not backported to JDK-17.

@openjdk
Copy link

openjdk bot commented Mar 1, 2024

@offamitkumar
8272903: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Mar 1, 2024
@openjdk
Copy link

openjdk bot commented Mar 1, 2024

@offamitkumar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272903: Missing license header in ArenaAllocator.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • ab602af: 8323210: Update the usage of cmsFLAGS_COPY_ALPHA

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Mar 1, 2024
@offamitkumar
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 2, 2024
@openjdk
Copy link

openjdk bot commented Mar 2, 2024

@offamitkumar
Your change (at version f431ff0) is now ready to be sponsored by a Committer.

@offamitkumar
Copy link
Member Author

@RealCLanger would you please sponsor this change?

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 4, 2024

Going to push as commit 3add2e3.
Since your change was applied there has been 1 commit pushed to the master branch:

  • ab602af: 8323210: Update the usage of cmsFLAGS_COPY_ALPHA

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 4, 2024
@openjdk openjdk bot closed this Mar 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 4, 2024
@openjdk
Copy link

openjdk bot commented Mar 4, 2024

@RealCLanger @offamitkumar Pushed as commit 3add2e3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants