Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8306040: HttpResponseInputStream.available() returns 1 on empty stream #2263

Closed

Conversation

SoniaZaldana
Copy link
Member

@SoniaZaldana SoniaZaldana commented Mar 1, 2024

Hi all,

This pull request contains a backport of commit acaab6fd74f507bb6b18167505d88e505bdf24bd from the openjdk/jdk repository.

Testing: using the reproducer linked in the issue, I was able to verify the patch.
I also ran the additional test case included in the original commit and all tests in test/jdk/java/net/httpclient/.

Note that patch is not clean because http tests and related classes have since been moved into a package of their own (namely /test/jdk/java/net/httpclient/lib), which doesn’t exist in jdk 17.

Only change introduced in my patch from the original commit:

@@ -25,7 +25,7 @@
  * @test
  * @bug 8306040
  * @summary HttpResponseInputStream.available() returns 1 on empty stream
- * @library /test/lib /test/jdk/java/net/httpclient/lib
+ * @library /test/lib
  * @run junit/othervm HttpInputStreamAvailableTest
  *
  */

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8306040 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8306040: HttpResponseInputStream.available() returns 1 on empty stream (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2263/head:pull/2263
$ git checkout pull/2263

Update a local copy of the PR:
$ git checkout pull/2263
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2263/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2263

View PR using the GUI difftool:
$ git pr show -t 2263

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2263.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 1, 2024

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport acaab6fd74f507bb6b18167505d88e505bdf24bd 8306040: HttpResponseInputStream.available() returns 1 on empty stream Mar 1, 2024
@openjdk
Copy link

openjdk bot commented Mar 1, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Mar 1, 2024
@SoniaZaldana
Copy link
Member Author

GHA failure: Unrelated Risk-V build issue.

@SoniaZaldana SoniaZaldana marked this pull request as ready for review March 6, 2024 14:23
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 6, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 6, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@SoniaZaldana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306040: HttpResponseInputStream.available() returns 1 on empty stream

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 63 new commits pushed to the master branch:

  • 9922f22: 8314832: Few runtime/os tests ignore vm flags
  • 6359b28: 8324632: Update Zlib Data Compression Library to Version 1.3.1
  • a8a8128: 8305169: java/security/cert/CertPathValidator/OCSP/GetAndPostTests.java -- test server didn't start in timely manner
  • 09f3890: 8297449: Update JInternalFrame Metal Border code
  • aa2cdb3: 8322503: Shenandoah: Clarify gc state usage
  • c0d209c: 8313307: java/util/Formatter/Padding.java fails on some Locales
  • e3ba201: Merge
  • 5fb5ba6: 8327391: Add SipHash attribution file
  • e100cf5: 8327036: [macosx-aarch64] SIGBUS in MarkActivationClosure::do_code_blob reached from Unsafe_CopySwapMemory0
  • 02eec99: 8328524: [x86] StringRepeat.java failure on linux-x86: Could not reserve enough space for 2097152KB object heap
  • ... and 53 more: https://git.openjdk.org/jdk17u-dev/compare/0052ab7061f01515d4f2a73566513f5f3476c518...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tstuefe) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@GoeLin
Copy link
Member

GoeLin commented Mar 20, 2024

Hi @SoniaZaldana, what about this change? It is pending for a long time now, and it should go to the July release please.

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Mar 20, 2024

⚠️ @SoniaZaldana This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Mar 20, 2024
@GoeLin
Copy link
Member

GoeLin commented Mar 21, 2024

Thanks for finishing this!

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 21, 2024
@SoniaZaldana
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 21, 2024
@openjdk
Copy link

openjdk bot commented Mar 21, 2024

@SoniaZaldana
Your change (at version 2cb26ca) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

shipilev commented Apr 2, 2024

RISC-V GHA failure is unrelated.

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 2, 2024

Going to push as commit 08debe8.
Since your change was applied there have been 95 commits pushed to the master branch:

  • 78f482d: 8318727: Enable parallelism in vmTestbase/vm/gc/concurrent tests
  • 5ecac7a: 8280377: MethodHandleProxies does not correctly invoke default methods with varags
  • 4ececad: 8306714: Open source few Swing event and AbstractAction tests
  • 151091c: 8305942: Open source several AWT Focus related tests
  • 996dfb0: 8305943: Open source few AWT Focus related tests
  • 615c01b: 8297292: java/nio/channels/FileChannel/FileExtensionAndMap.java is too slow
  • 8e132c4: 8163229: several regression tests have a main method that is never executed
  • 7680369: 8296610: java/net/HttpURLConnection/SetAuthenticator/HTTPSetAuthenticatorTest.java failed with "BindException: Address already in use: connect"
  • e59eeb0: 8297645: Drop the test/jdk/java/net/httpclient/reactivestreams-tck-tests/TckDriver.java test
  • b4e64ff: 8296137: diags-examples.xml is broken
  • ... and 85 more: https://git.openjdk.org/jdk17u-dev/compare/0052ab7061f01515d4f2a73566513f5f3476c518...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 2, 2024
@openjdk openjdk bot closed this Apr 2, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 2, 2024
@openjdk
Copy link

openjdk bot commented Apr 2, 2024

@shipilev @SoniaZaldana Pushed as commit 08debe8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
4 participants