8327036: [macosx-aarch64] SIGBUS in MarkActivationClosure::do_code_blob reached from Unsafe_CopySwapMemory0

[reinrich]

This pull request contains a backport of commit ad1d3248 from the openjdk/jdk21u-dev repository.

With the change the current thread switches to WXWrite mode before transitioning into the vm in JVM_ENTRY_FROM_LEAF.

Testing:
test/jdk/sun/nio/cs/FindDecoderBugs.java with -XX:+AssertWXAtThreadSync

The fix passed our CI testing: JTReg tests: tier1-4 of hotspot and jdk. All of Langtools and jaxp. JCK, SPECjvm2008, SPECjbb2015, Renaissance Suite, and SAP specific tests (also with ParallelGC).
Testing was done with fastdebug builds on the main platforms and also on Linux/PPC64le.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8327036 needs maintainer approval

Issue

• JDK-8327036: [macosx-aarch64] SIGBUS in MarkActivationClosure::do_code_blob reached from Unsafe_CopySwapMemory0 (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2269/head:pull/2269
$ git checkout pull/2269

Update a local copy of the PR:
$ git checkout pull/2269
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2269/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2269

View PR using the GUI difftool:
$ git pr show -t 2269

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2269.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rrich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[reinrich]

riscv64 build error is unrelated. See https://bugs.openjdk.org/browse/JDK-8326960

[openjdk]

⚠️ @reinrich This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (bc150336)

[openjdk]

@reinrich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327036: [macosx-aarch64] SIGBUS in MarkActivationClosure::do_code_blob reached from Unsafe_CopySwapMemory0

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• f221ff3: 8310031: Parallel: Implement better work distribution for large object arrays in old gen
• 08f1b35: 8320712: Rewrite BadFactoryTest in pure Java
• 6e73b11: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27
• 48327c3: 8309763: Move tests in test/jdk/sun/misc/URLClassPath directory to test/jdk/jdk/internal/loader
• fa8a159: 8282094: [REDO] Parallel: Refactor PSCardTable::scavenge_contents_parallel
• 3c05a02: 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop
• f423686: 8325972: Add -x to bash for building with LOG=debug
• 385731f: 8320303: Allow PassFailJFrame to accept single window creator
• 30ead33: 8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053
• 5421bb6: 8278893: Parallel: Remove GCWorkerDelayMillis
• ... and 4 more: https://git.openjdk.org/jdk17u-dev/compare/158f91a888020d1ea67682a07f6138737ea0cc67...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[reinrich]

/integrate

[openjdk]

Going to push as commit f38add6.
Since your change was applied there have been 19 commits pushed to the master branch:

• 4ba565c: 8266242: java/awt/GraphicsDevice/CheckDisplayModes.java failing on macOS 11 ARM
• e148b99: 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination
• 61fed7b: 8315677: Open source few swing JFileChooser and other tests
• f196e02: 8325137: com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java can fail in Xcomp with out of expected range
• 833e2bb: 8291753: Add JFR event for GC CPU Time
• f221ff3: 8310031: Parallel: Implement better work distribution for large object arrays in old gen
• 08f1b35: 8320712: Rewrite BadFactoryTest in pure Java
• 6e73b11: 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27
• 48327c3: 8309763: Move tests in test/jdk/sun/misc/URLClassPath directory to test/jdk/jdk/internal/loader
• fa8a159: 8282094: [REDO] Parallel: Refactor PSCardTable::scavenge_contents_parallel
• ... and 9 more: https://git.openjdk.org/jdk17u-dev/compare/158f91a888020d1ea67682a07f6138737ea0cc67...master

Your commit was automatically rebased without conflicts.

[openjdk]

@reinrich Pushed as commit f38add6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[reinrich]

/backport jdk11u-dev

[openjdk]

@reinrich the backport was successfully created on the branch backport-reinrich-f38add6f in my personal fork of openjdk/jdk11u-dev. To create a pull request with this backport targeting openjdk/jdk11u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit f38add6f from the openjdk/jdk17u-dev repository.

The commit being backported was authored by Richard Reingruber on 11 Mar 2024 and had no reviewers.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk11u-dev:

$ git fetch https://github.com/openjdk-bots/jdk11u-dev.git backport-reinrich-f38add6f:backport-reinrich-f38add6f
$ git checkout backport-reinrich-f38add6f
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk11u-dev.git backport-reinrich-f38add6f

⚠️ @reinrich You are not yet a collaborator in my fork openjdk-bots/jdk11u-dev. An invite will be sent out and you need to accept it before you can proceed.