-
Notifications
You must be signed in to change notification settings - Fork 232
8269373: some tests in jdk/tools/launcher/ fails on localized Windows platform #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
Pre-submit failure: gc/stringdedup/TestStringDeduplicationAgeThreshold.java#id1 Unrelated |
|
/integrate |
|
Going to push as commit 8197fd4.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 17.0.4-oracle.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/227/head:pull/227$ git checkout pull/227Update a local copy of the PR:
$ git checkout pull/227$ git pull https://git.openjdk.java.net/jdk17u-dev pull/227/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 227View PR using the GUI difftool:
$ git pr show -t 227Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/227.diff