-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8291753: Add JFR event for GC CPU Time #2270
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
|
GHA failure: Risc-V build issue, unrelated. |
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 833e2bb.
Your commit was automatically rebased without conflicts. |
I backport this as proposed before in #1900. Prereq changes are already done.
The backport has been tested by releaseing it in SapMachine in 17.0.10. This patch here is identical to the one in SapMachine. It will go to 17.0.12 giving enough time to settle.
The g1 files needed several trivial resolves due to context differences. Especially variable do_maximum_compaction was renamed to do_maximal_compaction. This appears several times in the context.
Further trivial resolves in
src/hotspot/share/gc/serial/defNewGeneration.hpp
src/hotspot/share/gc/shared/gcTrace.hpp
src/hotspot/share/gc/shared/genCollectedHeap.cpp
src/jdk.jfr/share/conf/jfr/profile.jfc
The whitespace fix is not needed in 17. Omitted.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2270/head:pull/2270
$ git checkout pull/2270
Update a local copy of the PR:
$ git checkout pull/2270
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2270/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2270
View PR using the GUI difftool:
$ git pr show -t 2270
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2270.diff
Webrev
Link to Webrev Comment