Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319372: C2 compilation fails with "Bad immediate dominator info" #2274

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 7, 2024

I backport this for parity with 17.0.12-oracle.

The change just removes one local optimization pattern in C2.
The change did not apply well as there are differences in comment
and whitespace, and a different error message.

Code wise the outermost if() differs.
As the inner pattern matching is the same, the problem
exists similarly in 11.

Tests pass.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8319372 needs maintainer approval

Issue

  • JDK-8319372: C2 compilation fails with "Bad immediate dominator info" (Bug - P2 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2274/head:pull/2274
$ git checkout pull/2274

Update a local copy of the PR:
$ git checkout pull/2274
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2274/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2274

View PR using the GUI difftool:
$ git pr show -t 2274

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2274.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 7, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7766785098816cfcdae3479540cdc866c1ed18ad 8319372: C2 compilation fails with "Bad immediate dominator info" Mar 7, 2024
@openjdk
Copy link

openjdk bot commented Mar 7, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 7, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 7, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 7, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@GoeLin
Copy link
Member Author

GoeLin commented Mar 11, 2024

GHA-failure: known Risc-V infra issue. Unrelated.

@openjdk openjdk bot added the approval label Mar 11, 2024
@openjdk
Copy link

openjdk bot commented Mar 11, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319372: C2 compilation fails with "Bad immediate dominator info"

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • f38add6: 8327036: [macosx-aarch64] SIGBUS in MarkActivationClosure::do_code_blob reached from Unsafe_CopySwapMemory0
  • 4ba565c: 8266242: java/awt/GraphicsDevice/CheckDisplayModes.java failing on macOS 11 ARM
  • e148b99: 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination
  • 61fed7b: 8315677: Open source few swing JFileChooser and other tests
  • f196e02: 8325137: com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java can fail in Xcomp with out of expected range
  • 833e2bb: 8291753: Add JFR event for GC CPU Time
  • f221ff3: 8310031: Parallel: Implement better work distribution for large object arrays in old gen

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 11, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Mar 11, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Mar 11, 2024

Going to push as commit f8cfa35.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 2d8a3a8: 8301381: Verify DTLS 1.0 cannot be negotiated
  • dd94e20: 8256660: Disable DTLS 1.0
  • f38add6: 8327036: [macosx-aarch64] SIGBUS in MarkActivationClosure::do_code_blob reached from Unsafe_CopySwapMemory0
  • 4ba565c: 8266242: java/awt/GraphicsDevice/CheckDisplayModes.java failing on macOS 11 ARM
  • e148b99: 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination
  • 61fed7b: 8315677: Open source few swing JFileChooser and other tests
  • f196e02: 8325137: com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java can fail in Xcomp with out of expected range
  • 833e2bb: 8291753: Add JFR event for GC CPU Time
  • f221ff3: 8310031: Parallel: Implement better work distribution for large object arrays in old gen

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 11, 2024
@openjdk openjdk bot closed this Mar 11, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 11, 2024
@openjdk
Copy link

openjdk bot commented Mar 11, 2024

@GoeLin Pushed as commit f8cfa35.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8319372 branch March 11, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants