Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315898: Open source swing JMenu tests #2275

Conversation

SoniaZaldana
Copy link
Member

@SoniaZaldana SoniaZaldana commented Mar 7, 2024

Hi all,

This pull request contains a backport of commit fecd2fd8 from the openjdk/jdk repository.

The commit being backported was authored by Abhishek Kumar on 13 Sep 2023 and was reviewed by Sergey Bylokhov.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8315898 needs maintainer approval

Issue

  • JDK-8315898: Open source swing JMenu tests (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2275/head:pull/2275
$ git checkout pull/2275

Update a local copy of the PR:
$ git checkout pull/2275
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2275/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2275

View PR using the GUI difftool:
$ git pr show -t 2275

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2275.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 7, 2024

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport fecd2fd8f26d0e8905a519e30e9aa171683c9df1 8315898: Open source swing JMenu tests Mar 7, 2024
@openjdk
Copy link

openjdk bot commented Mar 7, 2024

This backport pull request has now been updated with issue from the original commit.

@SoniaZaldana SoniaZaldana marked this pull request as ready for review March 8, 2024 15:45
@SoniaZaldana
Copy link
Member Author

GHA failure: Unrelated Risk-V build issue.

@openjdk
Copy link

openjdk bot commented Mar 8, 2024

⚠️ @SoniaZaldana This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added rfr Pull request is ready for review approval labels Mar 8, 2024
@mlbridge
Copy link

mlbridge bot commented Mar 8, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 11, 2024

@SoniaZaldana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315898: Open source swing JMenu tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • f8cfa35: 8319372: C2 compilation fails with "Bad immediate dominator info"
  • 2d8a3a8: 8301381: Verify DTLS 1.0 cannot be negotiated
  • dd94e20: 8256660: Disable DTLS 1.0
  • f38add6: 8327036: [macosx-aarch64] SIGBUS in MarkActivationClosure::do_code_blob reached from Unsafe_CopySwapMemory0
  • 4ba565c: 8266242: java/awt/GraphicsDevice/CheckDisplayModes.java failing on macOS 11 ARM
  • e148b99: 8317287: [macos14] InterJVMGetDropSuccessTest.java: Child VM: abnormal termination
  • 61fed7b: 8315677: Open source few swing JFileChooser and other tests
  • f196e02: 8325137: com/sun/management/ThreadMXBean/ThreadCpuTimeArray.java can fail in Xcomp with out of expected range
  • 833e2bb: 8291753: Add JFR event for GC CPU Time

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 11, 2024
@SoniaZaldana
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 11, 2024
@openjdk
Copy link

openjdk bot commented Mar 11, 2024

@SoniaZaldana
Your change (at version d0044e2) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Mar 12, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 12, 2024

Going to push as commit 49c260d.
Since your change was applied there have been 14 commits pushed to the master branch:

  • b632518: 8299858: [Metrics] Swap memory limit reported incorrectly when too large
  • 3433fdb: 8314283: Support for NSS tests on aarch64 platforms
  • 0606e5a: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries
  • a22ac46: 8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14
  • a14f845: 8320342: Use PassFailJFrame for TruncatedPopupMenuTest.java
  • f8cfa35: 8319372: C2 compilation fails with "Bad immediate dominator info"
  • 2d8a3a8: 8301381: Verify DTLS 1.0 cannot be negotiated
  • dd94e20: 8256660: Disable DTLS 1.0
  • f38add6: 8327036: [macosx-aarch64] SIGBUS in MarkActivationClosure::do_code_blob reached from Unsafe_CopySwapMemory0
  • 4ba565c: 8266242: java/awt/GraphicsDevice/CheckDisplayModes.java failing on macOS 11 ARM
  • ... and 4 more: https://git.openjdk.org/jdk17u-dev/compare/f221ff38300b5513a06e5755469668ef83556a3a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 12, 2024
@openjdk openjdk bot closed this Mar 12, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 12, 2024
@openjdk
Copy link

openjdk bot commented Mar 12, 2024

@GoeLin @SoniaZaldana Pushed as commit 49c260d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants