Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274233: Minor cleanup for ToolBox #228

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 10, 2022

I backport this for parity with 17.0.4-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/228/head:pull/228
$ git checkout pull/228

Update a local copy of the PR:
$ git checkout pull/228
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/228/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 228

View PR using the GUI difftool:
$ git pr show -t 228

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/228.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 10, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e741a18062061c1959f7881503aaf3a4cbcae776 8274233: Minor cleanup for ToolBox Mar 10, 2022
@openjdk
Copy link

openjdk bot commented Mar 10, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 10, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274233: Minor cleanup for ToolBox

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • f79a4ed: 8271224: runtime/EnclosingMethodAttr/EnclMethodAttr.java doesn't check exit code
  • 6fb49c3: 8269753: Misplaced caret in PatternSyntaxException's detail message

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 10, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 10, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Mar 11, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 11, 2022

Going to push as commit 08084ea.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 8197fd4: 8269373: some tests in jdk/tools/launcher/ fails on localized Windows platform
  • 6dcf10b: 8282509: [exploded image] ResolvedClassTest fails with similar output
  • 863631f: 8282225: GHA: Allow one concurrent run per PR only
  • d5e4f03: 8268558: [TESTBUG] Case 2 in TestP11KeyFactoryGetRSAKeySpec is skipped
  • feeb418: 8272146: Disable Fibonacci test on memory constrained systems
  • d3dc0cd: 8279515: C1: No inlining through invokedynamic and invokestatic call sites when resolved class is not linked
  • d413469: 8272169: runtime/logging/LoaderConstraintsTest.java doesn't build test.Empty
  • f79a4ed: 8271224: runtime/EnclosingMethodAttr/EnclMethodAttr.java doesn't check exit code
  • 6fb49c3: 8269753: Misplaced caret in PatternSyntaxException's detail message

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 11, 2022
@openjdk openjdk bot closed this Mar 11, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 11, 2022
@openjdk
Copy link

openjdk bot commented Mar 11, 2022

@GoeLin Pushed as commit 08084ea.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant