8273153: Consolidate file_exists into os:file_exists

[elifaslan1]

Clean backport to Consolidate file_exists into os:file_exists
This backport is required to close this backport clean.

Additional testing in addition to GHA tests

jtreg/tier2

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8273153 needs maintainer approval

Issue

• JDK-8273153: Consolidate file_exists into os:file_exists (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2281/head:pull/2281
$ git checkout pull/2281

Update a local copy of the PR:
$ git checkout pull/2281
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2281/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2281

View PR using the GUI difftool:
$ git pr show -t 2281

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2281.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back elifaslan1! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @elifaslan1 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (80997abb)

[openjdk]

@elifaslan1 usage: /approval [<id>] (request|cancel) [<text>]

[elifaslan1]

/approval JDK-8273153 request Clean backport to Consolidate file_exists into os:file_exists.This backport is required to close this backport clean. Tier2 and GHA tests passed

[openjdk]

@elifaslan1
JDK-8273153: The approval request has been created successfully.

[openjdk]

@elifaslan1 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273153: Consolidate file_exists into os:file_exists

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 198 new commits pushed to the master branch:

• 95f8dc0: 8316138: Add GlobalSign 2 TLS root certificates
• 0e524e2: 8324243: Compilation failures in java.desktop module with gcc 14
• fed9693: 8330815: Use pattern matching for instanceof in KeepAliveCache
• 261ad5e: 8331352: error: template-id not allowed for constructor/destructor in C++20
• d17fa03: 8328997: Remove unnecessary template parameter lists in GrowableArray
• 2440b24: 8319268: Build failure with GCC8.3.1 after 8313643
• 98038b3: 8330523: Reduce runtime and improve efficiency of KeepAliveTest
• 18bb8da: 8305819: LogConfigurationTest intermittently fails on AArch64
• 0a3445e: 8331942: On Linux aarch64, CDS archives should be using 64K alignment by default
• db04c7b: 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently
• ... and 188 more: https://git.openjdk.org/jdk17u-dev/compare/f221ff38300b5513a06e5755469668ef83556a3a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[bridgekeeper]

@elifaslan1 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[elifaslan1]

Hello @GoeLin ,
This backport is the first in a backport series that ends in JDK-8316468
There will be total of 3 backports to achieve this backport to be completed.
Please see Paul's comment here

[bridgekeeper]

@elifaslan1 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[elifaslan1]

Hello @GoeLin, please see my comment above. Thank you

[elifaslan1]

This backport is going to fix a crash seen in Amazon production @GoeLin . I am going to add this to my approval request to pass it to JBS issue.. TIA

[elifaslan1]

/approval JDK-8273153 request Clean backport to Consolidate file_exists into os:file_exists.This backport is required to close this backport clean. This backport is going to fix a crash seen on Amazon Production. Tier2 and GHA tests passed

[openjdk]

@elifaslan1
JDK-8273153: Approval has already been requested and rejected.

[elifaslan1]

/approval JDK-8273153 request Clean backport to Consolidate file_exists into os:file_exists.This backport is required to close this backport clean. This backport is going to fix a crash seen on Amazon Production. Tier2 and GHA tests passed

[openjdk]

@elifaslan1
JDK-8273153: The approval request has been updated successfully.

[elifaslan1]

/integrate

[openjdk]

@elifaslan1
Your change (at version 80997ab) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 6264c70.
Since your change was applied there have been 198 commits pushed to the master branch:

• 95f8dc0: 8316138: Add GlobalSign 2 TLS root certificates
• 0e524e2: 8324243: Compilation failures in java.desktop module with gcc 14
• fed9693: 8330815: Use pattern matching for instanceof in KeepAliveCache
• 261ad5e: 8331352: error: template-id not allowed for constructor/destructor in C++20
• d17fa03: 8328997: Remove unnecessary template parameter lists in GrowableArray
• 2440b24: 8319268: Build failure with GCC8.3.1 after 8313643
• 98038b3: 8330523: Reduce runtime and improve efficiency of KeepAliveTest
• 18bb8da: 8305819: LogConfigurationTest intermittently fails on AArch64
• 0a3445e: 8331942: On Linux aarch64, CDS archives should be using 64K alignment by default
• db04c7b: 8299023: TestPLABResize.java and TestPLABPromotion.java are failing intermittently
• ... and 188 more: https://git.openjdk.org/jdk17u-dev/compare/f221ff38300b5513a06e5755469668ef83556a3a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @elifaslan1 Pushed as commit 6264c70.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.